Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate useContext referance #423

Merged
merged 3 commits into from May 12, 2023
Merged

translate useContext referance #423

merged 3 commits into from May 12, 2023

Conversation

osmandlsmn
Copy link
Contributor

No description provided.

src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
src/content/reference/react/useContext.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@osmandlsmn osmandlsmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review için teşekkürler

@github-actions
Copy link

github-actions bot commented May 6, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 93.63 KB (🟡 +4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.2 KB (🟢 -671 B) 169.83 KB
/500 76.2 KB (🟢 -671 B) 169.82 KB
/[[...markdownPath]] 77.62 KB (🟢 -671 B) 171.25 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@baspinarenes baspinarenes self-requested a review May 6, 2023 07:57
@baspinarenes
Copy link
Contributor

Review notlarını resolve etmişsin ancak hala düzeltilmemiş gözüküyor. Düzeltebilir misin?

@baspinarenes baspinarenes marked this pull request as draft May 6, 2023 07:59
Copy link
Contributor Author

@osmandlsmn osmandlsmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge

@osmandlsmn osmandlsmn marked this pull request as ready for review May 8, 2023 19:54
@alioguzhan
Copy link
Member

Selam @osmandlsmn , degisik talep edilen yerler guncellenmemis sanirim. Merge icin onlar bekleniyor.

@osmandlsmn
Copy link
Contributor Author

Selam @osmandlsmn , degisik talep edilen yerler guncellenmemis sanirim. Merge icin onlar bekleniyor.

@baspinarenes'ın yaptığı reviewları approve edemiyorum Review Changes kısmında Approve butonu disabled durumda napmam gerekiyor tam olarak ?

@alioguzhan
Copy link
Member

Yanlis anlasilma oldu sanirim. @baspinarenes sizin yapmanizi istedigi degisiklikleri yazmis. Onlari sizin uygulamaniz gerekiyor. @osmandlsmn

@osmandlsmn
Copy link
Contributor Author

Bilgilendirme için teşekkürler değişiklikleri uyguladım.

@alioguzhan
Copy link
Member

Tesekkurler. @osmandlsmn

@baspinarenes hazir burasi sanirim.

@alioguzhan
Copy link
Member

Merge ediyorum ben @baspinarenes

@alioguzhan alioguzhan merged commit 6f06156 into reactjs:main May 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants