Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate <option> option - full #435

Merged
merged 10 commits into from May 9, 2023
Merged

Translate <option> option - full #435

merged 10 commits into from May 9, 2023

Conversation

K2adir
Copy link
Contributor

@K2adir K2adir commented May 6, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented May 6, 2023 •
edited

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@K2adir K2adir changed the title Option translated - Option translate - May 6, 2023
@K2adir K2adir changed the title Option translate - Translate <option> - full May 6, 2023
@K2adir K2adir changed the title Translate <option> - full Translate <option> option - full May 6, 2023
@alioguzhan
Copy link
Member

alioguzhan commented May 6, 2023 •
edited

Preview deploymenti basarisiz olmus. Bir yerde bir hata olabilir. Localde sitenin calisip calismadigini kontrol edebilir misiniz bu branchta ? Tesekkurler.

Sonrasinda review a baslarim.

@K2adir
fix - backtick error - tested OK
6f54c80 
Line 36, had a backtick problem,
this section " React, `<><AltEleman /></>`'dan `[<AltEleman />]`'a "

this commit fixes this.

tested on browser.
@K2adir
fix backticks - add missing ``
35d8150 
missing backticks added line 27
@K2adir
Copy link
Contributor Author

K2adir commented May 7, 2023 •
edited

fragment.md file had an issue with an extra backtick, fixing that, resolved the problem with the option.md file.
tested on the browser, double-checked with the English doc. All tests passed.

@alioguzhan good to go

alioguzhan
alioguzhan requested changes May 7, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler. Bir iki nokta var sadece. sonrasinde merge edebiliriz.

src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
src/content/reference/react-dom/components/option.md Outdated Show resolved Hide resolved
@K2adir K2adir requested a review from alioguzhan May 8, 2023 04:07
alioguzhan
alioguzhan approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler!

@alioguzhan alioguzhan merged commit 4f443f0 into reactjs:main May 9, 2023
4 checks passed
@alioguzhan alioguzhan mentioned this pull request May 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alioguzhan alioguzhan alioguzhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@K2adir @alioguzhan