Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burakcihan61/separating events from effects #493

Merged
merged 12 commits into from Oct 2, 2023
Merged

Burakcihan61/separating events from effects #493

merged 12 commits into from Oct 2, 2023

Conversation

burakcihan61
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@burakcihan61
Copy link
Contributor Author

@alioguzhan

@alioguzhan alioguzhan self-requested a review September 18, 2023 08:02
alioguzhan
alioguzhan requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elinize saglik.

Cok fazla duzeltimesi gereken yer vardi acikcasi. Normal sartlarda eksigi / hatasi cok fazla olan cevirileri reddediyoruz. Cunku review etmesi gercekten cok uzun suruyor.

Degisiklik yapilmasi gereken yerleri belirttim. Sadece bariz olanlari ekledim.

Tekrar ceviri yaparsaniz lutfen mumkun oldugunca dogru olduguna emin olduktan sonra PR acin.

Tekrardan elinize saglik. Tesekkurler.

src/content/learn/separating-events-from-effects.md Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
alioguzhan
alioguzhan requested changes Sep 24, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bir onceki reviewda belirttigim bazi yerleri gormediniz sanirim. Ya da bitmedi daha isiniz. Bir kac yenisini daha ekledim. SOnrasinda merge edebiliriz.

src/content/learn/separating-events-from-effects.md Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
src/content/learn/separating-events-from-effects.md Outdated Show resolved Hide resolved
@alioguzhan
Copy link
Member

Merhaba. Hala eksik yerler var. Soyle gostereyim: bu sayfada benim yaptigim review yorumlarini asagiya dogru tek tek okurken arada soyle bi alan var.

image

Load More yazisinda tikladiginizda gozunuzden kacan kisimlari da goreceksiniz. 9-10 tane daha yer var sanirim duzeltimesi gereken.

@alioguzhan
Copy link
Member

Bir de ek olarak, duzelttiginize emin oldugunuz kisimlari resolve diyerek collapse edebilirsiniz. Su an takip etmesi cok zor bir hal haldi bu PR. En azindan tamamlanmis olanlari gormeyiz. @burakcihan61

alioguzhan
alioguzhan approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler

@alioguzhan alioguzhan merged commit e59728f into reactjs:main Oct 2, 2023
4 checks passed
@alioguzhan alioguzhan mentioned this pull request Oct 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alioguzhan alioguzhan alioguzhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burakcihan61 @alioguzhan