translate legacy factories page #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for tr-reactjs ready! Built with commit 6cbb27d |
alioguzhan
requested changes
Mar 25, 2019
content/warnings/legacy-factories.md
Outdated
| @@ -54,6 +54,6 @@ function render(MyComponent) { | |||
| } | |||
| ``` | |||
|
|
|||
| ## In Depth {#in-depth} | |||
| ## Daha derin detay {#in-depth} | |||
There was a problem hiding this comment.
This might be more natural:
Daha Fazla Detay
| @@ -27,9 +27,9 @@ function render() { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Without JSX {#without-jsx} | |||
| ## JSX Olmadan {#without-jsx} | |||
There was a problem hiding this comment.
We can keep this. This describes a scenario. But below, (Dynamic components without JSX) it implies a name or an adjective. There is a tiny difference between them.
content/warnings/legacy-factories.md
Outdated
|
|
||
| ## Dynamic components without JSX {#dynamic-components-without-jsx} | ||
| ## JSX Olmadan dinamik bileşenler {#dynamic-components-without-jsx} |
There was a problem hiding this comment.
JSX'siz dinamik bileşenler
I believe we (others) used this pattern in other translations. So it is better to stick to it.
|
Hi I've implemented the improvements |
94 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.