Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Editor Setup #350

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

leduc1901
Copy link
Contributor

This is my translation on "Editor Setup"

I am writing to request a review of my pull request. I understand that your time is valuable, and I greatly appreciate any feedback you may have. Your review will help me improve the code and ensure that it meets the project's standards


</YouWillLearn>
</BạnSẽBiết>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird to show as a jsx tag. I don't think it's a good idea to translate it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will revert it

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Ryan-LT Ryan-LT merged commit 583a8f2 into reactjs:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants