Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Your First Component #354

Merged
merged 1 commit into from Apr 29, 2023

Conversation

ninh-nd
Copy link
Contributor

@ninh-nd ninh-nd commented Apr 28, 2023

I was happy that my previous PR got merged so this time I chose a "harder" page to translate. I would appreciate to receive some reviews on this one.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@ltmylinh ltmylinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great translation!

@ltmylinh ltmylinh merged commit 1335e38 into reactjs:main Apr 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants