Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation: Profiler #355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

leduc1901
Copy link
Contributor

This is my translation on "Profiler"

I am writing to request a review of my pull request. I understand that your time is valuable, and I greatly appreciate any feedback you may have. Your review will help me improve the code and ensure that it meets the project's standards

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


---

### `onRender` callback {/*onrender-callback*/}

React will call your `onRender` callback with information about what was rendered.
React sẽ gọi call `onRender` callback với thông tin về những gì được render.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we don't need an extra "call" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ! Thank you

@Ryan-LT
Copy link
Member

Ryan-LT commented Apr 30, 2023

@leduc1901 Thanks for the translation, looking good but it could be better. Could you please review it once more and add a bit more "natural" to the explaining?

@leduc1901
Copy link
Contributor Author

@leduc1901 Thanks for the translation, looking good but it could be better. Could you please review it once more and add a bit more "natural" to the explaining?

I just tweaked the translation so It could be more natural, can you help me to review it again ? @Ryan-LT thank you !

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌


### `<Profiler>` {/*profiler*/}

Wrap a component tree in a `<Profiler>` to measure its rendering performance.
Hãy bọc các component bên trong `<Profiler>` để đo lường hiệu suất.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "Hãy đặt" instead of "Hãy bọc"


* Profiling adds some additional overhead, so **it is disabled in the production build by default.** To opt into production profiling, you need to enable a [special production build with profiling enabled.](https://fb.me/react-profiling)
* Việc đo lường sẽ làm giảm hiệu suất, vì vậy **mặc định nó sẽ luôn được vô hiệu hoá trong bản build production.** Để đo lường ở production, bạn cần kích hoạt [tính năng đo lường trong một bản build production đặc biệt.](https://fb.me/react-profiling)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "trong phiên bản production" will be better than "trong bản build production"

@ltmylinh
Copy link
Collaborator

Hi @leduc1901 do you still want to continue working on this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants