docs(cn): add Thinking in React translations
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QC-L
requested review from
discountry,
hijiangtao,
QC-L,
dear-lizhihua and
lcxfs1991
yuqingc
requested changes
Feb 1, 2019
|
I'll wait for all the reviews to be finished before submitting a new commit. |
QC-L
reviewed
Feb 2, 2019
hijiangtao
requested changes
Feb 2, 2019
|
此 PR 建议再审校一遍。 |
|
感谢建议！ 但是个人认为：对于不涉及到具体使用的文档部分，只需要表达意思顺畅，能有效反映上下文内容即可。不应拘泥于原文，并期望与其保持严格的语句对应。否则就会像是在用中文写英文，失去了翻译的意义。 如： |
|
我在这句话加上标注的原因有两个：
|
|
已更新 commit，解决了大部分 review 的反馈。请大家继续审阅。 |
|
md 源文件似乎存在编码问题，可能是 Mac 下的键盘导致的，使得预览结果在 GitHub 上出现问号。我之后会处理。 |
|
@robertying 用的什么工具？是不是 VSCode? |
|
VSCode。之前在一个 commit message 上就出现过问号，所以应该不是文件编码问题，怀疑是中文键盘在一些情况下会添加奇怪的东西。不过 commit 也是用 VSCode 提的。 相关 issue：microsoft/vscode#37114 |
|
@robertying 建议 md 文件使用其他的，我用 VSCode 也出现过相同的问题。不知道是不是插件的问题。 |
hijiangtao
approved these changes
Feb 3, 2019
|
@hijiangtao 已经按照给出的建议修改，等 @dear-lizhihua 的后半部分 review。 |
dear-lizhihua
approved these changes
Feb 5, 2019
QC-L
pushed a commit
that referenced
this pull request
Feb 5, 2019
* docs(cn): add `Thinking in React` translations * docs(cn): add translation for `mock` * docs(cn): modify phrasing in regard to review suggestions * docs(cn): changes regarding review feedback * docs(cn): rephrase some words & remove control characters * docs(cn): revert Wikipedia links to English version * docs(cn): changes for overall smoothness
Closed
OhIAmFine
pushed a commit
to OhIAmFine/zh-hans.reactjs.org
that referenced
this pull request
May 6, 2019
* docs(cn): add `Thinking in React` translations * docs(cn): add translation for `mock` * docs(cn): modify phrasing in regard to review suggestions * docs(cn): changes regarding review feedback * docs(cn): rephrase some words & remove control characters * docs(cn): revert Wikipedia links to English version * docs(cn): changes for overall smoothness
|
Thinking in React 翻译成 “React编程思想” 可能会更通俗一点（参考那些 Thinking in Java, C++ 的书名译法） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retranslate the whole doc with limited reference to the old one. Phrasing style can be a lot different.
Open to suggestions. 🙂