Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate Render Props #176

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Conversation

huantingwei
Copy link
Contributor

Call for help for these phrases/word below:

  1. Cross-Cutting Concerns (line 21)
  2. reusable (current translation: 可重用)
  3. encapsulate (current translation: 封裝)

Please feel free to make comments or suggestion for the other parts as well. Thanks!

@netlify
Copy link

netlify bot commented Sep 4, 2020

Deploy preview for zh-hant-reactjs-org ready!

Built with commit c130846

https://deploy-preview-176--zh-hant-reactjs-org.netlify.app

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestion changes, if any question feels free to let me know, thank you for your translation!

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved

## Use Render Props for Cross-Cutting Concerns {#use-render-props-for-cross-cutting-concerns}
## Cross-Cutting Concerns 使用 Render Props{#use-render-props-for-cross-cutting-concerns}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
content/docs/render-props.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 added In Review Currently under review and removed Review Needed labels Sep 20, 2020
huantingwei and others added 2 commits September 28, 2020 17:20
Co-authored-by: Peng Jie <dean.leehom@gmail.com>
@huantingwei
Copy link
Contributor Author

@neighborhood999 Thanks for the awesome review! Please checkout the updated changes, thanks!

@neighborhood999
Copy link
Member

Thank you @huantingwei!

@neighborhood999 neighborhood999 merged commit e8d3f68 into reactjs:master Sep 29, 2020
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review labels Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants