Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: translate conditional rendering #18

Merged
merged 15 commits into from
Mar 7, 2019

Conversation

ivan-ha
Copy link
Contributor

@ivan-ha ivan-ha commented Feb 19, 2019

This PR translate the Conditional Rendering page.

Click to screen capture

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit d0d52fe

https://deploy-preview-18--zh-hant-reactjs.netlify.com

Copy link
Member

@chloewlin chloewlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ivan-ha ! Thank you for submitting this review. Good job. I think it's 99% done. Just fix all the 跟據 to 根據 and think about a few suggestions I made. We can merge this in very soon.

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
@ivan-ha
Copy link
Contributor Author

ivan-ha commented Feb 20, 2019

@chloewlin @neighborhood999 thanks for reviewing! I should have updated accordingly, just left one review unresolved and marked some comments.

Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just fix title in nav 👍

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
bugtender and others added 11 commits February 24, 2019 15:29
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 09e4ad2

https://deploy-preview-18--zh-hant-reactjs-org.netlify.com

@ivan-ha
Copy link
Contributor Author

ivan-ha commented Feb 24, 2019

thanks @bugtender @neighborhood999 , all comments resolved

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 320fe31

https://deploy-preview-18--zh-hant-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 2095807

https://deploy-preview-18--zh-hant-reactjs-org.netlify.com

@ivan-ha
Copy link
Contributor Author

ivan-ha commented Mar 5, 2019

@bugtender @chloewlin @neighborhood999 I should have resolved all comments, please let me know if there is anything pending

@neighborhood999 neighborhood999 merged commit b8dab29 into reactjs:master Mar 7, 2019
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review Revision Needed labels Mar 7, 2019
@ivan-ha ivan-ha deleted the doc/conditional-rendering branch March 7, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants