-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: translate conditional rendering #18
doc: translate conditional rendering #18
Conversation
Deploy preview for zh-hant-reactjs ready! Built with commit d0d52fe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ivan-ha ! Thank you for submitting this review. Good job. I think it's 99% done. Just fix all the 跟據
to 根據
and think about a few suggestions I made. We can merge this in very soon.
@chloewlin @neighborhood999 thanks for reviewing! I should have updated accordingly, just left one review unresolved and marked some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just fix title in nav 👍
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Deploy preview for zh-hant-reactjs-org ready! Built with commit 09e4ad2 |
320fe31
to
d0d52fe
Compare
thanks @bugtender @neighborhood999 , all comments resolved |
Deploy preview for zh-hant-reactjs-org ready! Built with commit 320fe31 |
Deploy preview for zh-hant-reactjs-org ready! Built with commit 2095807 |
@bugtender @chloewlin @neighborhood999 I should have resolved all comments, please let me know if there is anything pending |
This PR translate the Conditional Rendering page.
Click to screen capture