Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Advanced guides): React without ES6 #203

Merged
merged 4 commits into from
Mar 2, 2021
Merged

docs(Advanced guides): React without ES6 #203

merged 4 commits into from
Mar 2, 2021

Conversation

henry61024
Copy link
Contributor

@henry61024 henry61024 commented Feb 23, 2021 •
edited
Loading

Translate Advanced guides - React without ES6

@netlify
Copy link

netlify bot commented Feb 23, 2021 •
edited
Loading

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 78ee1a2

https://deploy-preview-203--zh-hant-reactjs-org.netlify.app

@henry61024
Copy link
Contributor Author

henry61024 commented Feb 23, 2021 •
edited
Loading

I would like to discuss about the translation of this articles' title: React Without ES6.

I personally think that 不使用 ES6 開發 React is more intuitive than the original translation 沒有 ES6 的 React, what is your thought on this?

However, the slight downside about choosing 不使用 ES6 開發 React is that we may need to unify the translation of React Without JSX as well.

@neighborhood999 neighborhood999 mentioned this pull request Feb 24, 2021
Closed
92 tasks
neighborhood999
neighborhood999 reviewed Feb 25, 2021
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@henry61024
Copy link
Contributor Author

I would like to discuss about the translation of this articles' title: React Without ES6.

I personally think that 不使用 ES6 開發 React is more intuitive than the original translation 沒有 ES6 的 React, what is your thought on this?

However, the slight downside about choosing 不使用 ES6 開發 React is that we may need to unify the translation of React Without JSX as well.

Hi, any thoughts on this?

@neighborhood999
Copy link
Member

neighborhood999 commented Mar 1, 2021 •
edited
Loading

I would like to discuss about the translation of this articles' title: React Without ES6.

I personally think that 不使用 ES6 開發 React is more intuitive than the original translation 沒有 ES6 的 React, what is your thought on this?

However, the slight downside about choosing 不使用 ES6 開發 React is that we may need to unify the translation of React Without JSX as well.

I think your opinion is great, can you help to update React Without JSX docs in this PR?

@henry61024
Copy link
Contributor Author

Of course, I'm glad to help!

@henry61024
Copy link
Contributor Author

I would like to discuss about the translation of this articles' title: React Without ES6.
I personally think that 不使用 ES6 開發 React is more intuitive than the original translation 沒有 ES6 的 React, what is your thought on this?
However, the slight downside about choosing 不使用 ES6 開發 React is that we may need to unify the translation of React Without JSX as well.

I think your opinion is great, can you help to update React Without JSX docs in this PR?

Updated in 78ee1a2

@neighborhood999 neighborhood999 merged commit f6aaf26 into reactjs:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neighborhood999 neighborhood999 neighborhood999 approved these changes

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henry61024 @neighborhood999