Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translation JavaScript in JSX #364

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

kai2128
Copy link
Contributor

@kai2128 kai2128 commented Mar 22, 2023

Translation beta document - JavaScript in JSX

@kai2128
Copy link
Contributor Author

kai2128 commented Mar 29, 2023

should I resolve the conversation?

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping, most are good to me. I reviewed it again and found some need to change, we're close!

If you update the review, feel free to resolve the review comments.

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, let's merge it!

@neighborhood999 neighborhood999 merged commit c7567c8 into reactjs:main Apr 10, 2023
@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis for react-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants