-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: translate js environment requirement #37
Conversation
Deploy preview for zh-hant-reactjs-org ready! Built with commit ac00adb |
@ivan-ha done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some suggestions.
React also depends on `requestAnimationFrame` (even in test environments). | ||
You can use the [raf](https://www.npmjs.com/package/raf) package to shim `requestAnimationFrame`: | ||
React 也依賴於 `requestAnimationFrame`(甚至包括測驗環境)。 | ||
你可以使用[raf](https://www.npmjs.com/package/raf) package 去 shim `requestAnimationFrame`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你可以使用[raf](https://www.npmjs.com/package/raf) package 去 shim `requestAnimationFrame`: | |
你可以使用 [raf](https://www.npmjs.com/package/raf) package 去模擬 `requestAnimationFrame`: |
The term shim
not sure can translate 模擬
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about shim
translate? Or maybe keep original term? cc @chloewlin @itszero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote for original because I really can't think of a good translation. If we do want to translate, I think a functional translation would be easier: something like "提供" as in providing that function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to keep the original, thank you for feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, thanks
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
Co-Authored-By: ivan-ha <hangolam@gmail.com>
translate the js environment requirement page
I'm not quite sure do we want to translate the word
package
andshim
, now I keep them in Englishagain @chloewlin could you help to label in #1 , thanks 🙇
Click to view screen capture