Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate js environment requirement #37

Merged
merged 4 commits into from
Mar 15, 2019

Conversation

ivan-ha
Copy link
Contributor

@ivan-ha ivan-ha commented Mar 10, 2019

translate the js environment requirement page
I'm not quite sure do we want to translate the word package and shim, now I keep them in English

again @chloewlin could you help to label in #1 , thanks 🙇

Click to view screen capture

@netlify
Copy link

netlify bot commented Mar 10, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit ac00adb

https://deploy-preview-37--zh-hant-reactjs-org.netlify.com

@chloewlin
Copy link
Member

@ivan-ha done!

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestions.

React also depends on `requestAnimationFrame` (even in test environments).
You can use the [raf](https://www.npmjs.com/package/raf) package to shim `requestAnimationFrame`:
React 也依賴於 `requestAnimationFrame`(甚至包括測驗環境)。
你可以使用[raf](https://www.npmjs.com/package/raf) package shim `requestAnimationFrame`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
你可以使用[raf](https://www.npmjs.com/package/raf) package 去 shim `requestAnimationFrame`
你可以使用 [raf](https://www.npmjs.com/package/raf) package 去模擬 `requestAnimationFrame`

The term shim not sure can translate 模擬.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about shim translate? Or maybe keep original term? cc @chloewlin @itszero

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for original because I really can't think of a good translation. If we do want to translate, I think a functional translation would be easier: something like "提供" as in providing that function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to keep the original, thank you for feedback.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, thanks

neighborhood999 and others added 3 commits March 13, 2019 00:53
Co-Authored-By: ivan-ha <hangolam@gmail.com>
@neighborhood999 neighborhood999 added In Review Currently under review Completed and removed Review Needed In Review Currently under review labels Mar 14, 2019
@neighborhood999 neighborhood999 merged commit 6aa4a24 into reactjs:master Mar 15, 2019
@ivan-ha ivan-ha deleted the docs/js-environment branch March 15, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants