Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Translate ReactDOM #38

Merged
merged 9 commits into from
Mar 25, 2019
Merged

doc: Translate ReactDOM #38

merged 9 commits into from
Mar 25, 2019

Conversation

abrcdf1023
Copy link
Contributor

@abrcdf1023 abrcdf1023 commented Mar 10, 2019 •
edited
Loading

Terms are not included in the Glossary.

  1. package
  2. React model
  3. polyfill
  4. container
  5. DOM
  6. reference
  7. ref
  8. hydrate
  9. server-render
  10. event listener
  11. markup
  12. text content
  13. fragment

The terms I'm quite not sure how to translate.

  1. escape hatch -> "出口" and "應急的做法"
  2. legacy -> "遺留的方式"

@netlify
Copy link

netlify bot commented Mar 10, 2019 •
edited
Loading

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 17b3fbd

https://deploy-preview-38--zh-hant-reactjs-org.netlify.com

@abrcdf1023
Copy link
Contributor Author

abrcdf1023 commented Mar 10, 2019 •
edited
Loading

I am not sure how to translate module. Should we keep it in English such as package ?

neighborhood999
neighborhood999 requested changes Mar 14, 2019
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abrcdf1023, thank you for your translation. I think before translate you should check our Glossary for terms translation, e.g. render do not translate 渲染.

cc @chloewlin for double check my reviewing, thank you.

content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 added In Review Currently under review and removed Review Needed labels Mar 14, 2019
@chloewlin
Copy link
Member

@abrcdf1023

For legacy, how about 既有程式碼?

@abrcdf1023
Copy link
Contributor Author

abrcdf1023 commented Mar 16, 2019 •
edited
Loading

@abrcdf1023

For legacy, how about 既有程式碼?

I think legacy is a negative term and I am not sure if we can translate it properly. Maybe 老舊的程式碼 is more reach this term.

@abrcdf1023 abrcdf1023 changed the title Translate ReactDOM done. doc: Translate ReactDOM. Mar 18, 2019
@abrcdf1023 abrcdf1023 changed the title doc: Translate ReactDOM. doc: Translate ReactDOM Mar 18, 2019
neighborhood999
neighborhood999 reviewed Mar 18, 2019
View reviewed changes
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor change

@tesseralis tesseralis mentioned this pull request Mar 22, 2019
Closed
92 tasks
@abrcdf1023
Copy link
Contributor Author

@chloewlin, I translate legacy into 遺留的方式. I think is better than before.

@abrcdf1023
Copy link
Contributor Author

abrcdf1023 commented Mar 24, 2019 •
edited
Loading

Hi all, I clean up terms that are not included in the Glossary maybe we can update it.

bugtender
bugtender reviewed Mar 24, 2019
View reviewed changes
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abrcdf1023 . Looks great.
If there's no more big issue. I will merge it tomorrow. 👌

@bugtender bugtender merged commit 5a47a5f into reactjs:master Mar 25, 2019
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review labels Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neighborhood999 neighborhood999 neighborhood999 requested changes

@chloewlin chloewlin chloewlin left review comments

@bugtender bugtender bugtender approved these changes

Assignees
No one assigned
Labels
Completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abrcdf1023 @chloewlin @bugtender @neighborhood999