Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: translate add react to a website #45

Merged
merged 3 commits into from
Apr 2, 2019

Conversation

fabianlee1211
Copy link
Contributor

@fabianlee1211 fabianlee1211 commented Mar 31, 2019

This PR is ready for review!

I left these untranslated:

  • bundler
  • preprocessor
  • composition

And I'm not sure translating production to 正式發佈.
The translation (生产环境) for it in Simplified Chinese feels kind of awkward to me.

@netlify
Copy link

netlify bot commented Mar 31, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 175718c

https://deploy-preview-45--zh-hant-reactjs-org.netlify.com

@chloewlin chloewlin self-requested a review April 1, 2019 01:18
@chloewlin chloewlin added the In Review Currently under review label Apr 1, 2019
Copy link
Member

@chloewlin chloewlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianlee1211 I made some suggestions but this is overall very good! I am also not sure about production. @neighborhood999 what do you think?

content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
Co-Authored-By: fabianlee1211 <chleefabian@gmail.com>
Copy link
Member

@chloewlin chloewlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianlee1211 I've consulted the opinions of some contributors in the community. @itszero and @neighborhood999 both recommend 線上環境. Can you take a look at the changes?

content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
content/docs/add-react-to-a-website.md Outdated Show resolved Hide resolved
Co-Authored-By: fabianlee1211 <chleefabian@gmail.com>
@fabianlee1211
Copy link
Contributor Author

@chloewlin Thanks for the help!

@chloewlin
Copy link
Member

I think this is ready. Thank you @fabianlee1211!

@chloewlin chloewlin merged commit 92e14a1 into reactjs:master Apr 2, 2019
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabianlee1211, thank you for your translation. Can you create another PR for updating below suggestions?

content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
content/docs/add-react-to-a-website.md Show resolved Hide resolved
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review Revision Needed labels Apr 2, 2019
@fabianlee1211
Copy link
Contributor Author

Hi @neighborhood999 ! Just submitted another PR for the suggestions! Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants