-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: translate add react to a website #45
doc: translate add react to a website #45
Conversation
Deploy preview for zh-hant-reactjs-org ready! Built with commit 175718c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabianlee1211 I made some suggestions but this is overall very good! I am also not sure about production. @neighborhood999 what do you think?
Co-Authored-By: fabianlee1211 <chleefabian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabianlee1211 I've consulted the opinions of some contributors in the community. @itszero and @neighborhood999 both recommend 線上環境
. Can you take a look at the changes?
Co-Authored-By: fabianlee1211 <chleefabian@gmail.com>
@chloewlin Thanks for the help! |
I think this is ready. Thank you @fabianlee1211! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabianlee1211, thank you for your translation. Can you create another PR for updating below suggestions?
Hi @neighborhood999 ! Just submitted another PR for the suggestions! Thanks again :) |
This PR is ready for review!
I left these untranslated:
bundler
preprocessor
composition
And I'm not sure translating
production
to正式發佈
.The translation (生产环境) for it in Simplified Chinese feels kind of awkward to me.