Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Test Utilities #56

Merged
merged 7 commits into from
May 19, 2019
Merged

doc: Test Utilities #56

merged 7 commits into from
May 19, 2019

Conversation

vrabe
Copy link
Contributor

@vrabe vrabe commented May 14, 2019

Translations of some words are not consistent in API Reference:

  • overview (概觀 or 概覽)
  • reference (參考, 參考資料, or no translation)

Terms I don't translate:

  • boilerplate code
  • dispatch

I'm not sure how to translate:

  • We recommend using react-testing-library which is designed to enable and encourage writing tests that use your components as the end users do. (Line 22)
  • ... a simple <div> containing any provided children. (Line 138)
    提供的 is weird.
  • input field (Line 335)

@netlify
Copy link

netlify bot commented May 14, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit fe4e976

https://deploy-preview-56--zh-hant-reactjs-org.netlify.com

@vrabe vrabe changed the title Test utils doc: Test Utilities May 14, 2019
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any question, feel free left some comments.

content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
content/docs/addons-test-utils.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 added the In Review Currently under review label May 15, 2019
@neighborhood999 neighborhood999 merged commit 58e836f into reactjs:master May 19, 2019
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants