Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Homepage] initial translation #6

Merged
merged 10 commits into from
Feb 20, 2019

Conversation

itszero
Copy link
Contributor

@itszero itszero commented Feb 10, 2019

Taking the first stab at the homepage!

We haven't got an official glossary list yet so I'm taking some liberty here. It's mostly straightforward but I decided to rewrite a few sentences to make it more readable. (I prefer to make the translation more readable/smooth rather than stick to the original structure)

I also somewhat localized the examples code a bit so it feels more approachable.

A few comments:

  • hooks was used in the external plugins example. I removed it to prevent confusion with the React Hooks (and also that word is tricky to translate into TC, I think broader Taiwanese programming community, as in outside of React like Windows MFC community, mostly just use the word hook directly so I'd like to avoid that confusion.) nvm lol. Pulled the master and found out that upstream made the same change too.
  • Going with a bit more localized terms than English terms -- happy to tweak the ratio here!
  • Translated header/footer too

src/pages/index.js Outdated Show resolved Hide resolved
src/pages/index.js Outdated Show resolved Hide resolved
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itszero I left some minor change suggestion, thank you.

content/home/examples/a-simple-component.js Outdated Show resolved Hide resolved
content/home/examples/a-simple-component.md Outdated Show resolved Hide resolved
content/home/examples/an-application.md Outdated Show resolved Hide resolved
content/home/marketing/component-based.md Outdated Show resolved Hide resolved
content/home/marketing/declarative.md Outdated Show resolved Hide resolved
content/home/marketing/declarative.md Outdated Show resolved Hide resolved
@itszero
Copy link
Contributor Author

itszero commented Feb 20, 2019

Thanks for the review. I think i've updated everything!

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit 2bee91e

https://deploy-preview-6--zh-hant-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit df64cfd

https://deploy-preview-6--zh-hant-reactjs.netlify.com

@chloewlin chloewlin merged commit 9909550 into reactjs:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants