Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: translate hooks-rules #63

Merged
merged 6 commits into from
Jul 2, 2019

Conversation

KevinHu2014
Copy link
Contributor

Ready for first time review.

@netlify
Copy link

netlify bot commented Jun 5, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit a28c1f0

https://deploy-preview-63--zh-hant-reactjs-org.netlify.com

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. If you have any question feel free to comment in the below.

@@ -1,73 +1,73 @@
---
id: hooks-rules
title: Rules of Hooks
title: Hook 規則
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hook 的規則

content/docs/hooks-rules.md Outdated Show resolved Hide resolved

Hooks are JavaScript functions, but you need to follow two rules when using them. We provide a [linter plugin](https://www.npmjs.com/package/eslint-plugin-react-hooks) to enforce these rules automatically:
Hook 是 JavaScript function,但你在使用他們時需要遵守兩個規則。 我們提供了一個 [linter plugin](https://www.npmjs.com/package/eslint-plugin-react-hooks) 來自動化地實行這些規則:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Hook 是 JavaScript function,但你在使用他們時需要遵守兩個規則。 我們提供了一個 [linter plugin](https://www.npmjs.com/package/eslint-plugin-react-hooks) 來自動化地實行這些規則
Hook 是 JavaScript function,當你使用它們時需要遵守兩個規則。 我們提供了一個 [linter plugin](https://www.npmjs.com/package/eslint-plugin-reat-hooks) 來自動化地執行這些規則

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing character c in react

content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
Kevin and others added 4 commits June 30, 2019 20:01
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@KevinHu2014
Copy link
Contributor Author

KevinHu2014 commented Jun 30, 2019

Hi @neighborhood999
I have apply the suggestions and sorry for separating those changes in multiple commits.
Ready for second time review.
Thanks for the help!

content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants