Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate hooks API reference #69

Merged
merged 7 commits into from
Aug 7, 2019

Conversation

ivan-ha
Copy link
Contributor

@ivan-ha ivan-ha commented Jun 25, 2019

Done.
Not finished all, create this draft PR to kickstart review first.

TODO:

  • useImperativeHandle
  • useLayoutEffect
  • useDebugValue
  • sidebar menu

@netlify
Copy link

netlify bot commented Jun 25, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit bfb14af

https://deploy-preview-69--zh-hant-reactjs-org.netlify.com

@ivan-ha ivan-ha force-pushed the docs/hooks-api-reference branch 2 times, most recently from a047e03 to 1637b0f Compare June 25, 2019 15:49
@ivan-ha ivan-ha force-pushed the docs/hooks-api-reference branch 2 times, most recently from 84beb41 to fdbf32d Compare June 29, 2019 02:17
@ivan-ha ivan-ha marked this pull request as ready for review June 29, 2019 02:17
@ivan-ha ivan-ha closed this Jun 29, 2019
@ivan-ha ivan-ha reopened this Jun 29, 2019
@ivan-ha
Copy link
Contributor Author

ivan-ha commented Jun 29, 2019

@neighborhood999 the PR is ready for review, thanks!

@chloewlin chloewlin added In Review Currently under review and removed Review Needed labels Jul 12, 2019
@neighborhood999
Copy link
Member

Hi @ivan-ha

the hooks-reference is conflict.

@ivan-ha
Copy link
Contributor Author

ivan-ha commented Jul 16, 2019

thanks @neighborhood999 , resolved

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If have any questions, feel free leave your comment.

ivan-ha and others added 5 commits July 30, 2019 00:41
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@ivan-ha
Copy link
Contributor Author

ivan-ha commented Jul 29, 2019

thanks @neighborhood999 , all resolved!

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivan-ha

Sorry for late check updated because I'm busy recently. Here are some minor change required, thanks for your help.

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 added Revision Needed and removed In Review Currently under review labels Aug 4, 2019
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@ivan-ha
Copy link
Contributor Author

ivan-ha commented Aug 7, 2019

thanks @neighborhood999, updated again

@neighborhood999
Copy link
Member

@ivan-ha Thank you! Merged.

@neighborhood999 neighborhood999 merged commit 5b24ecb into reactjs:master Aug 7, 2019
@ivan-ha ivan-ha deleted the docs/hooks-api-reference branch August 16, 2019 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants