Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: synthetic-event branch #81

Merged
merged 32 commits into from Jul 27, 2019
Merged

docs: synthetic-event branch #81

merged 32 commits into from Jul 27, 2019

Conversation

chloewlin
Copy link
Member

@chloewlin chloewlin commented Jul 7, 2019

7/6 Set up synthetic-event branch
7/6 This PR is ready for review

  • Overview
  • Event Pooling
  • Supported Events
  • Reference

@netlify
Copy link

netlify bot commented Jul 7, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 92bc2aa

https://deploy-preview-81--zh-hant-reactjs-org.netlify.com

@chloewlin chloewlin changed the title Set up synthetic-event branch docs: synthetic-event branch Jul 7, 2019
Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! and sorry for late reviewing. 😅

content/docs/reference-events.md Outdated Show resolved Hide resolved
Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Reference section, I prefer to keep event name to the original term. If have any problem, feel free discuss in the under.

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
chloewlin and others added 12 commits July 26, 2019 23:25
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
chloewlin and others added 16 commits July 26, 2019 23:29
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin
Copy link
Member Author

Thank you, @bugtender and @neighborhood999, for your careful and thorough reviews. I've updated everything you suggested and will merge this in soon.

@chloewlin chloewlin merged commit 478ae54 into reactjs:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants