-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CD to GitHub Actions #180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the CD to GitHub Actions, with a few adjustments: - CI is now only run on pull requests (ci.yml) - Pushes to master trigger the `snapshot.yml` worflow which runs tests in one job then publishes to Artifactory /libs-snapshot-local in a second job - Publishing a GitHub Release or PreRelease triggers `release.yml` - the tag is used as the `version`, so it must end with .RELEASE or represent a pre-release and include .RC or .M (this is added as a condition to the publishing jobs) - tests are not run, as it is assumed that snapshot tests have been verified by the maintainer who triggers the release - prereleases go to Artifactory /libs-milestone-local - GA releases still go to Bintray for now Segregation of deployments into two jobs allow to use an environment and thus properly gate access to secrets. It also gives an opportunity to avoid all 3rd party actions in the critical parts of the workflow. Fixes #159.
Some caveats of the previous CI/CD and release process listed while working on this PR:
|
…s required (since environment protection rules drive the manual approval, and we only want that control on milestones/releases)
bsideup
reviewed
Mar 25, 2021
bsideup
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a minor clarification
Co-authored-by: Sergei Egorov <segorov@vmware.com>
violetagg
approved these changes
Mar 25, 2021
bsideup
approved these changes
Mar 25, 2021
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches the CD to GitHub Actions, with a few adjustments:
snapshot.yml
worflow which runs testsin one job then publishes to Artifactory /libs-snapshot-local in a
second job
release.yml
version
, so it must end with .RELEASE orrepresent a pre-release and include .RC or .M (this is added as a
condition to the publishing jobs)
verified by the maintainer who triggers the release
Segregation of deployments into two jobs allow to use an environment and
thus properly gate access to secrets. It also gives an opportunity to
avoid all 3rd party actions in the critical parts of the workflow.
Fixes #159.