Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide BlockHoundRuntime from public API #53

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

bsideup
Copy link
Contributor

@bsideup bsideup commented Oct 1, 2019

BlockHoundRuntime must be public because it is injected into bootstrap ClassLoader and being accessed from the JDK classes later.

But we don't want the users to call it, since it should only be used from the instrumentation.

This change makes the original class internal and changes the visibility with ASM when we inject it into the bootstrap ClassLoader.

@bsideup bsideup added this to the 1.0.0.RC2 milestone Oct 1, 2019
@bsideup bsideup mentioned this pull request Oct 1, 2019
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to mention it in caveats of a RC2 release notes

Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to mention it in caveats of a RC2 release notes

@bsideup bsideup merged commit b121197 into master Oct 1, 2019
@bsideup bsideup deleted the hide_runtime_from_public_API branch October 1, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants