Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockHound should use specific Error sub-type #64

Closed
normanmaurer opened this issue Oct 25, 2019 · 1 comment · Fixed by #65
Closed

BlockHound should use specific Error sub-type #64

normanmaurer opened this issue Oct 25, 2019 · 1 comment · Fixed by #65
Labels
area/java-agent good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Milestone
next

Comments

@normanmaurer
Copy link

Would it make sense to throw a specific Error sub-type to make it easier for users to do something that fits for them.

For example something like public class BlockingOperationError extends Error
@bsideup bsideup added the good first issue Ideal for a new contributor, we'll help label Oct 25, 2019
@bsideup bsideup added this to the next milestone Oct 25, 2019
@bsideup
Copy link
Contributor

bsideup commented Oct 25, 2019

@normanmaurer good idea. Will leave it as "good first issue" for a few days, but will make sure it is included in the next release 👍

@bsideup bsideup added area/java-agent type/enhancement A general enhancement labels Oct 25, 2019
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 27, 2019
@bhchandra
Throw specific BlockingOperationError instead of Error (reactor#64)
34fb649
@bhchandra bhchandra mentioned this issue Oct 27, 2019
Merged
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 29, 2019
@bhchandra
Add copyright to BlockingOperationError (reactor#64)
9032714
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 29, 2019
@bhchandra
Capture the BlockingMethod as a field of BlockingOperationError (reac…
13bc281 
…tor#64)
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 29, 2019
@bhchandra
Use simple Error in documentation instead of BlockingOperationError t…
df21974 
…o demonstrate that there is no magic in BlockingOperationError and any error can be used (reactor#64)
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 30, 2019
@bhchandra
Rename field blockingMethod -> method in BlockingOperationError (r…
3379b21 
…eactor#64)
bhchandra added a commit to bhchandra/BlockHound that referenced this issue Oct 30, 2019
@bhchandra
Update Readme with BlockingOperationError (reactor#64)
5d01e76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/java-agent good first issue Ideal for a new contributor, we'll help type/enhancement A general enhancement
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Throw specific BlockingOperationError instead of Error bhchandra/BlockHound
2 participants
@normanmaurer @bsideup