Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating Retry (removal in 3.6.0) #278

Closed
simonbasle opened this issue Mar 11, 2022 · 0 comments
Closed

Deprecating Retry (removal in 3.6.0) #278

simonbasle opened this issue Mar 11, 2022 · 0 comments
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Milestone
3.4.7

Comments

@simonbasle
Copy link
Member

Unlike Repeat, which still doesn't have an equivalent in reactor-core, Retry can be entirely replaced by the (better implemented) RetrySpec from reactor-core.

It is time to deprecate Retry class in addons.
@simonbasle simonbasle added type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations labels Mar 11, 2022
@simonbasle simonbasle added this to the 3.4.7 milestone Mar 11, 2022
@simonbasle simonbasle mentioned this issue Mar 11, 2022
Open
simonbasle added a commit that referenced this issue Mar 11, 2022
@simonbasle
Deprecate Retry, superseded by core's RetrySpec
a546617 
This commit deprecates Retry and associated classes that are not shared
with the sister Repeat utility. While the later doesn't have a core
equivalent yet, Retry is superseded by core's `RetrySpec` (as well as
`RetryBackoffSpec`).

Fixes #278.
@simonbasle simonbasle mentioned this issue Mar 11, 2022
Merged
@chemicL chemicL mentioned this issue Jul 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Milestone
3.4.7
Development

No branches or pull requests
1 participant
@simonbasle