Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a convenience method for doing both a final expectXXX and a verify #43

Closed
simonbasle opened this issue Dec 1, 2016 · 0 comments
Closed

Provide a convenience method for doing both a final expectXXX and a verify #43

simonbasle opened this issue Dec 1, 2016 · 0 comments
Assignees
@simonbasle
Labels
archived/reactor-test (archived) This belongs to the reactor-test module type/enhancement A general enhancement
Milestone
3.0.4.RELEASE

Comments

@simonbasle
Copy link
Member

Having the StepVerifier layer, as currently returned by methods from FinalStep (expectComplete, expectError, thenCancel), is still necessary:

  • there is an overload with a timeout Duration
  • there is the possibility to trigger log()ging
  • in the future it could be possible to get a Subscriber rather than triggering subscription and verification...

That said, concern has been raised that the verify() step is easy to forget. Maybe adding a convenience sibling method to all these FinalStep methods that also triggers a verification would help. It would only cover the case where no log() is triggered and no timeout is used.

For example, verifyComplete() would call .expectComplete().verify()...
@simonbasle simonbasle added archived/reactor-test (archived) This belongs to the reactor-test module type/enhancement A general enhancement labels Dec 1, 2016
@simonbasle simonbasle modified the milestone: Reactor Addons 3.0.4.RELEASE Dec 1, 2016
@simonbasle simonbasle self-assigned this Dec 5, 2016
simonbasle added a commit that referenced this issue Dec 5, 2016
@simonbasle
fix #43 Convenience expect-and-verify methods
f607e3d
simonbasle added a commit to reactor/reactor-core that referenced this issue May 31, 2017
@simonbasle
fix 43 Convenience expect-and-verify methods
5d4ac1d 
This commit adds methods that combine `expectError`/`expectComplete`
with a call to the simple `.verify()` variant of `StepVerifier`.

For more advanced usage where one desires to have logging or timeout,
the usual expect method followed by the relevant `log()`,`verify()` or
`verify(Duration)` call should be used instead.

(fix reactor/reactor-addons#43)
simonbasle added a commit to reactor/reactor-core that referenced this issue May 31, 2017
@simonbasle
fix 43 Convenience expect-and-verify methods
d6344d9 
This commit adds methods that combine `expectError`/`expectComplete`
with a call to the simple `.verify()` variant of `StepVerifier`.

For more advanced usage where one desires to have logging or timeout,
the usual expect method followed by the relevant `log()`,`verify()` or
`verify(Duration)` call should be used instead.

(fix reactor/reactor-addons#43)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
archived/reactor-test (archived) This belongs to the reactor-test module type/enhancement A general enhancement
Projects
None yet
Milestone
3.0.4.RELEASE
Development

No branches or pull requests
1 participant
@simonbasle