Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DirectProcessor and UnicastProcessor documentation outdated #1149

Closed
codependent opened this issue Mar 29, 2018 · 5 comments
Closed

DirectProcessor and UnicastProcessor documentation outdated #1149

codependent opened this issue Mar 29, 2018 · 5 comments
Labels
good first issue Ideal for a new contributor, we'll help type/documentation A documentation update
Milestone

Comments

@codependent
Copy link

Expected behavior

direct (DirectProcessor and UnicastProcessor): These processors can only push data through direct user action (calling their Sink's methods directly).

Actual behavior

Both processors can subscribe to upstream Publishers

Steps to reproduce

Described here: https://stackoverflow.com/questions/49536849/why-does-a-unicastprocessor-plus-connectableflux-send-previously-emitted-items-d

Reactor Core version

3.1.5.RELEASE

JVM version (e.g. java -version)

1.8

@simonbasle simonbasle added type/documentation A documentation update good first issue Ideal for a new contributor, we'll help labels Mar 30, 2018
@simonbasle simonbasle added this to the 3.2.0.RELEASE milestone Mar 30, 2018
@OlegDokuka
Copy link
Contributor

Will fix it this weekends.

OlegDokuka added a commit to OlegDokuka/reactor-core that referenced this issue May 15, 2018
OlegDokuka added a commit to OlegDokuka/reactor-core that referenced this issue May 16, 2018
OlegDokuka added a commit to OlegDokuka/reactor-core that referenced this issue May 16, 2018
OlegDokuka added a commit to OlegDokuka/reactor-core that referenced this issue May 16, 2018
OlegDokuka added a commit to OlegDokuka/reactor-core that referenced this issue May 16, 2018
smaldini pushed a commit that referenced this issue May 17, 2018
@simonbasle simonbasle modified the milestones: 3.2.0.RELEASE, 3.2.0.M2 May 17, 2018
@OlegDokuka
Copy link
Contributor

@simonbasle do we need any other fixes there?

@simonbasle
Copy link
Member

simonbasle commented May 18, 2018

@OlegDokuka don't think so, your PR has been merged. Unfortunately @smaldini blindly reused your initial commit message which was not super explicit and didn't start with "fix", preventing GitHub to detect which issue to close. I'll close manually.

@codependent
Copy link
Author

@OlegDokuka @simonbasle having a look at the commits they only reference the javadoc, but what about the project documentation?

direct (DirectProcessor and UnicastProcessor): These processors can only push data through direct user action (calling their Sink's methods directly).

Maybe I missed the commit...

Regards!

@gdrouet
Copy link

gdrouet commented Aug 5, 2020

@simonbasle @OlegDokuka I can subscribe to a Publisher with a UnicastProcessor which drains all its data. The documentation does not tell that as reported by this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for a new contributor, we'll help type/documentation A documentation update
Projects
None yet
Development

No branches or pull requests

4 participants