Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit5 migration polishing tasks on 3.2.x #2436

Closed
6 tasks done
simonbasle opened this issue Oct 14, 2020 · 0 comments
Closed
6 tasks done

JUnit5 migration polishing tasks on 3.2.x #2436

simonbasle opened this issue Oct 14, 2020 · 0 comments
Assignees
@simonbasle
Labels
type/chores A task not related to code (build, formatting, process, ...)
Milestone
3.2.21.RELEASE

Comments

@simonbasle
Copy link
Member

simonbasle commented Oct 14, 2020 •
edited

Follow-up to #2344 / #2395, polishing things on 3.2.x

  • Fix compile options that were mistakenly changed in JavaConventions (maxwarns and maxerrs to be set to 500 so as to eg. limit the number of back and forth when fixing an common usage pattern change across all tests)
  • in ExceptionTest, move the @BeforeEach higher in the file
  • in FluxReplayTest, move the vts field + @BeforeEach/@AfterEach higher in the file (before first @Test)
  • use @Tag in GuideTest#populateDebug() rather than display name
  • fix bad line breaks in SchedulersTest, clean up dead code and static classes/field positions in the file
  • fix bad line breaks in AbstractSchedulerTest
@simonbasle simonbasle added the type/chores A task not related to code (build, formatting, process, ...) label Oct 14, 2020
@simonbasle simonbasle added this to the 3.2.21.RELEASE milestone Oct 14, 2020
@simonbasle simonbasle self-assigned this Oct 14, 2020
This was referenced Oct 14, 2020
Closed
Merged
simonbasle added a commit that referenced this issue Oct 15, 2020
@simonbasle
fix #2436 Polish some 3.2 JUnit5 tests and compiler options
b4054f3 
This commit is a follow-up to #2344 / #2395, polishing things on 3.2.x.
simonbasle added a commit that referenced this issue Oct 15, 2020
@simonbasle
Merge #2436 into 3.3.11.RELEASE
780562e
simonbasle added a commit that referenced this issue Oct 15, 2020
@simonbasle
Merge #2436 into 3.4.0
59a35ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Milestone
3.2.21.RELEASE
Development

No branches or pull requests
1 participant
@simonbasle