Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1342 Let collectList discard accumulated elements on error/cancel #1345

Merged
merged 1 commit into from Sep 12, 2018

Conversation

simonbasle
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #1345 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1345      +/-   ##
============================================
+ Coverage     83.93%   84.09%   +0.15%     
- Complexity     3852     3857       +5     
============================================
  Files           356      356              
  Lines         29355    29377      +22     
  Branches       5434     5446      +12     
============================================
+ Hits          24640    24704      +64     
+ Misses         3098     3066      -32     
+ Partials       1617     1607      -10
Impacted Files Coverage Δ Complexity Δ
...n/java/reactor/core/publisher/MonoCollectList.java 80% <100%> (+1.05%) 2 <0> (ø) ⬇️
...ore/src/main/java/reactor/core/publisher/Flux.java 98.73% <0%> (+0.01%) 509% <0%> (ø) ⬇️
...ava/reactor/core/publisher/FluxBufferBoundary.java 93.66% <0%> (+0.04%) 3% <0%> (ø) ⬇️
...va/reactor/core/publisher/FluxMergeSequential.java 82.17% <0%> (+0.06%) 6% <0%> (ø) ⬇️
...java/reactor/core/scheduler/ExecutorScheduler.java 78.76% <0%> (+0.14%) 12% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/FluxReplay.java 83.9% <0%> (+0.3%) 25% <0%> (+1%) ⬆️
...n/java/reactor/core/publisher/ImmutableSignal.java 84.78% <0%> (+0.33%) 23% <0%> (ø) ⬇️
...eactor/core/publisher/ParallelMergeSequential.java 80.31% <0%> (+0.51%) 7% <0%> (ø) ⬇️
...c/main/java/reactor/core/publisher/RingBuffer.java 71.51% <0%> (+0.94%) 24% <0%> (ø) ⬇️
...ava/reactor/core/publisher/EventLoopProcessor.java 80.82% <0%> (+1.03%) 53% <0%> (+2%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5debc1...236f101. Read the comment docs.

@smaldini smaldini merged commit e337f0e into master Sep 12, 2018
@smaldini smaldini added this to the 3.2.0.RELEASE milestone Sep 12, 2018
@simonbasle simonbasle deleted the 1342-discardOnCollectListCancel branch October 3, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants