Basic tracking support #1481
Closed
Basic tracking support #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
============================================
- Coverage 84.2% 84.03% -0.17%
- Complexity 3907 3926 +19
============================================
Files 359 363 +4
Lines 29920 30086 +166
Branches 5566 5581 +15
============================================
+ Hits 25194 25284 +90
- Misses 3096 3168 +72
- Partials 1630 1634 +4
Continue to review full report at Codecov.
|
bsideup
commented
Jan 15, 2019
| @@ -1268,4 +1282,37 @@ else if (s2 != null) { | |||
| return both; | |||
| } | |||
|
|
|||
| private static class MultiSubscriber<T> implements CoreSubscriber<T> { | |||
There was a problem hiding this comment.
This is hacky but didn't know how to do it better
) `ContextRunnable` is a new abstraction for the context passing. It implements newly introduced `ContextAware` interface and forces the implementors to provide a context (either current or empty). old `Runnable`-based methods are marked as `@Deprecated` to enforce the usage of the `ContextRunnable`.
# Conflicts: # reactor-core/src/main/java/reactor/core/CorePublisher.java # reactor-core/src/main/java/reactor/core/publisher/Flux.java # reactor-core/src/main/java/reactor/core/publisher/Mono.java # reactor-core/src/main/java/reactor/core/publisher/ParallelFlux.java
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://github.com/reactor with 1 occurrences migrated to: https://github.com/reactor ([https](https://github.com/reactor) result 200). * http://projectreactor.io/docs/core/release/api/ with 3 occurrences migrated to: https://projectreactor.io/docs/core/release/api/ ([https](https://projectreactor.io/docs/core/release/api/) result 200). * http://projectreactor.io/docs/test/release/api/ with 1 occurrences migrated to: https://projectreactor.io/docs/test/release/api/ ([https](https://projectreactor.io/docs/test/release/api/) result 200). * http://www.apache.org/licenses/LICENSE-2.0 with 6 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). * http://www.apache.org/licenses/LICENSE-2.0.txt with 1 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0.txt ([https](https://www.apache.org/licenses/LICENSE-2.0.txt) result 200). * http://www.reactive-streams.org/reactive-streams-1.0.2-javadoc/ with 3 occurrences migrated to: https://www.reactive-streams.org/reactive-streams-1.0.2-javadoc/ ([https](https://www.reactive-streams.org/reactive-streams-1.0.2-javadoc/) result 200). * http://repo.spring.io/libs-milestone with 1 occurrences migrated to: https://repo.spring.io/libs-milestone ([https](https://repo.spring.io/libs-milestone) result 302). * http://repo.spring.io/libs-snapshot with 1 occurrences migrated to: https://repo.spring.io/libs-snapshot ([https](https://repo.spring.io/libs-snapshot) result 302). * http://repo.spring.io/plugins-release with 1 occurrences migrated to: https://repo.spring.io/plugins-release ([https](https://repo.spring.io/plugins-release) result 302).
|
@bsideup, |
|
HI @robotmrv, We decided to split it into smaller chunks (see #1527 and #1546) for now. These PRs duplicate what we did in the tracing one, with an exception of the ContextAware Runnables (see #1524, also closed since most of tracing solutions rely on thread locals anyways), and a common tracking interface (no longer needed given the provided abstractions) We may consider integrating Reactor with some tracing solutions in future, but that will be another PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.