Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Correct flux subscribe example in faq #2924

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Conversation

liukun2634
Copy link
Contributor

@liukun2634 liukun2634 commented Feb 16, 2022

Fix: subscribe() return type is Disposable, so remove incorrect return variable Flux<String> secrets in doc.

@liukun2634 liukun2634 requested a review from a team as a code owner February 16, 2022 12:56
@pivotal-cla
Copy link

@kaka2634 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@kaka2634 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@liukun2634 liukun2634 changed the title [doc]Correct flux subscribe example in faq [doc] Correct flux subscribe example in faq Feb 16, 2022
@liukun2634
Copy link
Contributor Author

@pivotal-cla This is an Obvious Fix

@pivotal-cla
Copy link

@kaka2634 This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@simonbasle simonbasle added the type/documentation A documentation update label Feb 16, 2022
@simonbasle simonbasle added this to the 3.4.16 milestone Feb 16, 2022
@simonbasle simonbasle merged commit 9bbe8be into reactor:main Feb 16, 2022
gcf-merge-on-green bot pushed a commit to GoogleCloudPlatform/cloud-sql-jdbc-socket-factory that referenced this pull request Mar 25, 2022
….16 (#778)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [io.projectreactor:reactor-core](https://togithub.com/reactor/reactor-core) | `3.4.15` -> `3.4.16` | [![age](https://badges.renovateapi.com/packages/maven/io.projectreactor:reactor-core/3.4.16/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/io.projectreactor:reactor-core/3.4.16/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/io.projectreactor:reactor-core/3.4.16/compatibility-slim/3.4.15)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/io.projectreactor:reactor-core/3.4.16/confidence-slim/3.4.15)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>reactor/reactor-core</summary>

### [`v3.4.16`](https://togithub.com/reactor/reactor-core/releases/v3.4.16)

[Compare Source](https://togithub.com/reactor/reactor-core/compare/v3.4.15...v3.4.16)

Reactor-Core `3.4.16` is part of **`2020.0.17` Release Train (`Europium` SR17)**.

This service release contains a few bugfixes and improvements.

#### What's Changed

##### ✨ New features and improvements

-   Improve BoundedElasticScheduler to be less blocking by [@&#8203;simonbasle](https://togithub.com/simonbasle) in [reactor/reactor-core#2909
-   Add EmitFailureHandler.busyLoop flavor by [@&#8203;Animesh27](https://togithub.com/Animesh27) in [reactor/reactor-core#2943

##### 🐞 Bug fixes

-   Fix Mono.then not cancelling between Callable sources by [@&#8203;simonbasle](https://togithub.com/simonbasle) in [reactor/reactor-core#2934

##### 📖 Documentation, Tests and Build

-   Update Gradle to v7.4 in [reactor/reactor-core#2922
-   \[doc] Correct flux subscribe example in faq by [@&#8203;liukun2634](https://togithub.com/liukun2634) in [reactor/reactor-core#2924
-   Show how-to-fix hints in CI when preliminary steps fail (check of license headers, api compatibility) by [@&#8203;simonbasle](https://togithub.com/simonbasle) in [reactor/reactor-core#2932
-   \[guide] Remove ref to Swing/SwtScheduler in addons appendix by [@&#8203;simonbasle](https://togithub.com/simonbasle) in [reactor/reactor-core#2959
-   \[build] Have jcstress part of slowerChecks by [@&#8203;simonbasle](https://togithub.com/simonbasle) in [reactor/reactor-core#2958

##### 🆙 Dependency Upgrades

-   Update plugin spotless to v6.3.0 in [reactor/reactor-core#2925
-   Update plugin bnd to v6.2.0 in [reactor/reactor-core#2941
-   Update dependency org.awaitility:awaitility to v4.2.0 in [reactor/reactor-core#2945
-   Update dependency ch.qos.logback:logback-classic to v1.2.11 in [reactor/reactor-core#2946
-   Update dependency com.tngtech.archunit:archunit to v0.23.1 in [reactor/reactor-core#2940
-   Update plugin japicmp to v0.4.0 in [reactor/reactor-core#2948
-   Update dependency org.mockito:mockito-core to v4.4.0 in [reactor/reactor-core#2951
-   Update plugin download to v5.0.2 in [reactor/reactor-core#2950

#### New Contributors

-   [@&#8203;Animesh27](https://togithub.com/Animesh27) made their first contribution in [reactor/reactor-core#2943 👍

**Full Changelog**: reactor/reactor-core@v3.4.15...v3.4.16

</details>

---

### Configuration

📅 **Schedule**: "after 8am on Friday,before 12pm on Friday" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants