Add StateLogger for structured logging of state machines #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 12, 2022 22:37
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
added 2 commits
June 16, 2022 11:26
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
simonbasle
requested changes
Jun 16, 2022
There was a problem hiding this comment.
nice !
a few minor polishing suggestions:
- even if it is package-private I would consider adding minimal javadoc to
StateLogger - maybe a minimal amount on
FastLoggertoo (it is public, but in jcstress folder) - I would consider adding a constructor for subscribers eg.
SwitchOnFirstConditionalMainwithout theStateLoggerparameter, rather than having to change all unit tests to pass innull
added 2 commits
June 17, 2022 17:21
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
|
@simonbasle done |
simonbasle
approved these changes
Jun 17, 2022
simonbasle
added
type/enhancement
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds state logger useful for state machine debugging purpose
Signed-off-by: Oleh Dokuka odokuka@vmware.com