Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework guide on Retry with Transient Errors #3093

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

simonbasle
Copy link
Member

This commit reworks the reference guide section on Retry with Transient
Errors, improving the explanation and adding more details in a separate
section.

The code snippet has also been changed to reflect a more practical use
case, with the original artificial Flux<Integer> split out in a
secondary snippet.

Supersedes #3079.

@simonbasle simonbasle requested a review from a team as a code owner June 29, 2022 09:31
@simonbasle simonbasle added this to the 3.4.20 milestone Jun 29, 2022
@simonbasle simonbasle added the type/documentation A documentation update label Jun 29, 2022
@simonbasle simonbasle self-assigned this Jun 29, 2022
@simonbasle simonbasle requested a review from a team June 29, 2022 09:31
@simonbasle
Copy link
Member Author

@lynch19 FYI this PR is my rework of the explanations around transient error retry.

Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the copyright end year

docs/asciidoc/coreFeatures.adoc Outdated Show resolved Hide resolved
reactor-core/src/test/java/reactor/guide/GuideTests.java Outdated Show resolved Hide resolved
@simonbasle
Copy link
Member Author

@lynch19 I'll defer merging until tomorrow to give you a chance to review the wording and confirm this makes the documentation more understandable

@simonbasle simonbasle merged commit e94fe2c into 3.4.x Jul 6, 2022
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@simonbasle simonbasle deleted the refGuideTransientErrorRetry branch July 6, 2022 12:33
simonbasle added a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants