Fix a couple reactor-core-micrometer module compilation errors #3132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Micrometer#useRegistry has been removed but the scheduler hook was still referencing it instead of the (deprecated) one in core. This fixes the situation by using core's Metrics.MicrometerConfiguration getRegistry. The hook could be removed entirely from the micrometer module with the upcoming introduction of TimedScheduler there.
simonbasle
added
area/observability
type/bug
|
somehow when #3128 was split, removing scheduler-related changes, it didn't trigger any tests and we didn't pick that compilation problem during the rebasing :( |
simonbasle
added
type/chores
violetagg
approved these changes
Jul 28, 2022
simonbasle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Micrometer#useRegistry has been removed but the scheduler hook
was still referencing it instead of the (deprecated) one in core.
This fixes the situation by using core's Metrics.MicrometerConfiguration
getRegistry.
The hook could be removed entirely from the micrometer module with the
upcoming introduction of TimedScheduler there.