Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds cancellation of the source future support #3146

Merged
merged 3 commits into from
Aug 15, 2022
Merged

adds cancellation of the source future support #3146

merged 3 commits into from
Aug 15, 2022

Conversation

OlegDokuka
Copy link
Contributor

closes #3138

Signed-off-by: Oleh Dokuka odokuka@vmware.com

adds cancellation of the source future support
923f934 
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
@OlegDokuka OlegDokuka requested a review from a team as a code owner August 10, 2022 10:17
@OlegDokuka OlegDokuka changed the base branch from main to 3.4.x August 10, 2022 10:17
@OlegDokuka OlegDokuka added the type/enhancement A general enhancement label Aug 10, 2022
@OlegDokuka OlegDokuka added this to the 3.4.23 milestone Aug 10, 2022
Oleh Dokuka added 2 commits August 10, 2022 13:34
cleanups
b8ff0a4 
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
fixes failing test
f983f32 
Signed-off-by: Oleh Dokuka <odokuka@vmware.com>
Signed-off-by: OlegDokuka <odokuka@vmware.com>
simonbasle
simonbasle approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@simonbasle simonbasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely cause some conflict when merging into main, but not too hard to solve. feel free to merge this @OlegDokuka 👍

@OlegDokuka OlegDokuka merged commit 18ce835 into 3.4.x Aug 15, 2022
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka OlegDokuka mentioned this pull request Aug 16, 2022
Closed
@simonbasle
Copy link
Member

merged into 3.5.0-M6 via commit ebfc60a

@simonbasle simonbasle deleted the enhancement/3.4.x-3138 branch August 16, 2022 08:33
@steven-sheehy
Copy link

I believe the Mono.fromFuture() docs are now incorrect after this change:

Note that the future is not cancelled when that Mono is cancelled, but that behavior can be obtained by using a doFinally(Consumer) that checks for a SignalType.CANCEL and calls CompletableFuture.cancel(boolean).

@simonbasle
Copy link
Member

I believe the Mono.fromFuture() docs are now incorrect after this change:

Note that the future is not cancelled when that Mono is cancelled, but that behavior can be obtained by using a doFinally(Consumer) that checks for a SignalType.CANCEL and calls CompletableFuture.cancel(boolean).

that's a good point 👍
do you want to submit a doc PR to 3.4.x branch @steven-sheehy ?

@He-Pin He-Pin mentioned this pull request Sep 26, 2022
Open
@benwiles1 benwiles1 mentioned this pull request Oct 17, 2022
Closed
@OlegDokuka OlegDokuka mentioned this pull request Oct 26, 2022
Merged
OlegDokuka added a commit that referenced this pull request Oct 28, 2022
@OlegDokuka
fixes breaking change for fromFuture source cancellation (#3252)
7068604 
this commits fixes misleading documentation introduced after #3146. Also, this commit adds extra methods overloads which allow suppression of the cancellation propagation to the observed `Future`
@xinlian12 xinlian12 mentioned this pull request Nov 2, 2022
Merged
@chemicL chemicL mentioned this pull request Nov 2, 2022
Closed
chemicL pushed a commit that referenced this pull request Mar 7, 2023
@OlegDokuka @chemicL
fixes breaking change for fromFuture source cancellation (#3252)
b99e32c 
this commits fixes misleading documentation introduced after #3146. Also, this commit adds extra methods overloads which allow suppression of the cancellation propagation to the observed `Future`
@hobo05 hobo05 mentioned this pull request May 17, 2023
Closed
This was referenced May 28, 2023
Open
Open
Open
@chemicL chemicL mentioned this pull request Mar 6, 2024
Closed
@rohitrajwani rohitrajwani mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemicL chemicL chemicL approved these changes

@simonbasle simonbasle simonbasle approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
3.4.23
Development

Successfully merging this pull request may close these issues.

Propagate cancel signal on Mono to wrapped CompletableFuture
5 participants
@OlegDokuka @reactorbot @simonbasle @steven-sheehy @chemicL