ExecutorScheduler should use onScheduleHook #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ExecutorScheduler` did not wrap tasks with `onScheduleHook` configured in `Schedulers`. This can lead to various unexpected situations, but an apparent one is that automatic context propagation to `ThreadLocal`s does not work when an `ExecutorScheduler` is used by any operator. Fixes #3355.
chemicL
added
type/bug
OlegDokuka
approved these changes
Feb 16, 2023
|
@chemicL this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
chemicL
added a commit
that referenced
this pull request
Feb 16, 2023
chemicL
added a commit
that referenced
this pull request
Mar 7, 2023
`ExecutorScheduler` did not wrap tasks with `onScheduleHook` configured in `Schedulers`. This can lead to various unexpected situations, but an apparent one is that automatic context propagation to `ThreadLocal`s does not work when an `ExecutorScheduler` is used by any operator. Fixes #3355.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutorSchedulerdid not wrap tasks withonScheduleHookconfigured inSchedulers. This can lead to various unexpected situations, but an apparent one is that automatic context propagation toThreadLocals does not work when anExecutorScheduleris used by any operator.Fixes #3355.