Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes error handling for fmSequential consistent with flatMap #3397

Merged
merged 2 commits into from
Apr 10, 2023
Merged

makes error handling for fmSequential consistent with flatMap #3397

merged 2 commits into from
Apr 10, 2023

Conversation

eralmansouri
Copy link
Contributor

closes #3396

@eralmansouri eralmansouri requested a review from a team as a code owner March 12, 2023 21:10
@pivotal-cla
Copy link

@eralmansouri Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@eralmansouri Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@eralmansouri Thank you for signing the Contributor License Agreement!

@eralmansouri eralmansouri force-pushed the bugfix/onnext-err-#3396 branch 2 times, most recently from 9814d68 to 3f2d3eb Compare March 13, 2023 01:36
@OlegDokuka
Copy link
Contributor

Thanks for the PR, @eralmansouri! Awesome job!
Can you please include a test from the original issue to prove all work fine?

Thanks,
Oleh

@OlegDokuka OlegDokuka added the type/enhancement A general enhancement label Mar 15, 2023
@OlegDokuka OlegDokuka added this to the 3.5.5 milestone Mar 15, 2023
@eralmansouri
Copy link
Contributor Author

@OlegDokuka I added a test to show it works. It is slightly ugly because I couldn't use AssertSubscriber here.

@OlegDokuka OlegDokuka changed the base branch from main to 3.4.x April 3, 2023 07:06
@OlegDokuka OlegDokuka changed the base branch from 3.4.x to main April 3, 2023 07:06
@OlegDokuka
Copy link
Contributor

@eralmansouri can you please rebase your PR on 3.4.x

@eralmansouri
Copy link
Contributor Author

@OlegDokuka

Ok rebased onto 3.4.x

@OlegDokuka OlegDokuka changed the base branch from main to 3.4.x April 4, 2023 09:30
@OlegDokuka OlegDokuka changed the title Make error handling for flatMapSequential consistent with flatMap makes error handling for fmSequential consistent with flatMap Apr 10, 2023
@OlegDokuka OlegDokuka merged commit aa051cd into reactor:3.4.x Apr 10, 2023
5 checks passed
@reactorbot
Copy link

@OlegDokuka this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

@OlegDokuka
Copy link
Contributor

congrats @eralmansouri on your first merged PR 🎉!
Good work. Keep it up!

Look forward to seeing more fixes from you!

OlegDokuka pushed a commit that referenced this pull request Apr 10, 2023
Merge #3397 into 3.5.5
7c5cc07 
Signed-off-by: OlegDokuka <odokuka@vmware.com>
@wyhasany wyhasany mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
3.5.5
Development

Successfully merging this pull request may close these issues.

Inconsistent error handling with flatMap vs flatMapSequential
4 participants
@eralmansouri @pivotal-cla @OlegDokuka @reactorbot