ensures SignalListener#addToContext exceptions are handled #3415
Conversation
chemicL
added
type/bug
| @@ -661,6 +712,47 @@ void doFirst() { | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| void throwingAlterContext() { | |||
There was a problem hiding this comment.
I guess those duplicate tests could be implemented through Stream<Consumer[TestSubscriber]> so you pass subscriber and then check that it received onError
There was a problem hiding this comment.
It's part of a @Nested test. I believe the original suite was meant to group by operator type (combinations of conditonal/fuseable/regular with flux/mono) and in a nested class have all that's appropriate at the cost of duplication. Do I understand correctly that you'd like to change the paradigm - have just doFirst, throwingAlterContext, throwingCreateListener, etc. that accept consumers and make their assertions as generic validations, but have the logic in the Stream of parameters that consume a TestSubscriber? If it can be done, perhaps it can be addressed in a different PR? Rewriting it here would blur the point this PR is making. Unless of course, I misunderstood your intention?
| catch (Throwable e) { | ||
| IllegalStateException listenerError = new IllegalStateException( | ||
| "Unable to augment tap Context at subscription via addToContext", e); | ||
| signalListener.handleListenerError(listenerError); |
There was a problem hiding this comment.
Looking at this handler I wonder what if it throws exception as well
There was a problem hiding this comment.
The javadoc says the following:
This method MUST return normally, i.e. it MUST NOT throw..
The original design assumes therefore, that ignoring this warning can lead to unspecified behaviour.
OlegDokuka
changed the title
Fixes #3414