Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in legend svg #3710

Merged
merged 2 commits into from
Apr 11, 2024
Merged

typo in legend svg #3710

merged 2 commits into from
Apr 11, 2024

Conversation

Hailong
Copy link
Contributor

@Hailong Hailong commented Feb 2, 2024

No description provided.

@Hailong Hailong requested a review from a team as a code owner February 2, 2024 16:12
@pivotal-cla
Copy link

@Hailong Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@Hailong Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Hailong Thank you for signing the Contributor License Agreement!

Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a suggestion, please include it if it makes sense.

docs/asciidoc/images/legend-events.svg Outdated Show resolved Hide resolved
@chemicL
Copy link
Member

chemicL commented Feb 13, 2024

Hey @Hailong it's been a while, are you still willing to push the contribution forward?

@chemicL chemicL added this to the 3.7.0-M2 milestone Apr 11, 2024
@chemicL chemicL added the type/documentation A documentation update label Apr 11, 2024
@chemicL chemicL merged commit 22ba538 into reactor:main Apr 11, 2024
7 checks passed
@chemicL
Copy link
Member

chemicL commented Apr 11, 2024

@Hailong I incorporated my suggestion and merged. Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants