Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3772: wrapped with await().untilAsserted #3779

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

chickenchickenlove
Copy link
Contributor

Wrapped Assertions.assertThat(disposable.isDisposed()).isTrue() with Awaitility.await().
Because disposable.dispose() is not finished yet right after latch reaches zero.

Fixes #3772

Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think it's a good approach. Please rebase to target the 3.6.x branch and let's merge it 🚀

@chickenchickenlove
Copy link
Contributor Author

chickenchickenlove commented Apr 10, 2024

@chemicL Thanks for your comment 🙇‍♂️
I executed this command to rebase to 3.6.x.
Please take a look when you have free time!

$ git remote add upstream https://github.com/reactor/reactor-core.git
$ git checkout -b 3.6.x upstream/3.6.x
$ git checkout 240330-test-fix
$ git rebase 3.6.x # conflict occurs at gradle.properties (i resolved it)
$ git push --force

@chemicL chemicL changed the base branch from main to 3.6.x April 10, 2024 13:07
@chemicL
Copy link
Member

chemicL commented Apr 10, 2024

Thanks! I changed the base and I think there won't be any issue, but next time consider using --onto as an argument to rebase. Check here for justifications. When the tests pass we can merge it :)

@chemicL chemicL added the type/test A change in test sources label Apr 10, 2024
@chemicL chemicL added this to the 3.6.6 milestone Apr 10, 2024
@chemicL chemicL added type/test/flaky and removed type/test A change in test sources labels Apr 10, 2024
@chickenchickenlove
Copy link
Contributor Author

I see. thanks for your kindful comments 🙇‍♂️

@chemicL chemicL merged commit c9fdc64 into reactor:3.6.x Apr 11, 2024
7 checks passed
chemicL added a commit that referenced this pull request Apr 11, 2024
@chemicL
Copy link
Member

chemicL commented Apr 11, 2024

Thank you for the contribution @chickenchickenlove 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundedElasticThreadPerTaskSchedulerTest > ensuresTasksScheduling() FAILED
2 participants