Fix Out of Order Commits After Rebalance #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves reactor#259 Consumer could be permanently paused if a partition is reassigned and duplicate records received. - purge deferred and uncommitted offset commits when a partition is revoked - protect against duplicate entries in both maps Also fix a small race where `isPaused()` returns false in `onRequest()` but the consumer is about to be paused, preventing wake up - only an issue with long poll timeouts.
|
This change looks good to me |
simonbasle
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #259
Consumer could be permanently paused if a partition is reassigned and
duplicate records received.
Also fix a small race where
isPaused()returns false inonRequest()but theconsumer is about to be paused, preventing wake up - only an issue with long
poll timeouts.