Skip to content

Commit

Permalink
Merge branch '0.8.x'
Browse files Browse the repository at this point in the history
  • Loading branch information
violetagg committed Oct 25, 2019
2 parents f15fd62 + 062521e commit 7b7f380
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Expand Up @@ -61,7 +61,7 @@ ext {
assertJVersion = '3.6.1'

// Libraries
nettyVersion = '4.1.42.Final'
nettyVersion = '4.1.43.Final'
jacksonDatabindVersion = '2.5.1'

// Testing
Expand Down Expand Up @@ -258,7 +258,7 @@ configure(rootProject) { project ->
testRuntime "ch.qos.logback:logback-classic:$logbackVersion"

// Needed for HTTP/2 testing
testRuntime "io.netty:netty-tcnative-boringssl-static:2.0.25.Final" + os_suffix
testRuntime "io.netty:netty-tcnative-boringssl-static:2.0.26.Final" + os_suffix

jarFileTestCompile 'org.assertj:assertj-core:3.12.2'
jarFileTestCompile 'junit:junit:4.12'
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/reactor/netty/http/client/HttpClientSecure.java
Expand Up @@ -24,7 +24,6 @@
import io.netty.handler.codec.http2.Http2SecurityUtil;
import io.netty.handler.ssl.ApplicationProtocolConfig;
import io.netty.handler.ssl.ApplicationProtocolNames;
import io.netty.handler.ssl.OpenSsl;
import io.netty.handler.ssl.SslContext;
import io.netty.handler.ssl.SslContextBuilder;
import io.netty.handler.ssl.SslHandler;
Expand Down Expand Up @@ -77,7 +76,8 @@ protected TcpClient tcpConfiguration() {
SslContext sslCtx;
try {
io.netty.handler.ssl.SslProvider provider =
OpenSsl.isAlpnSupported() ? io.netty.handler.ssl.SslProvider.OPENSSL :
io.netty.handler.ssl.SslProvider.isAlpnSupported(io.netty.handler.ssl.SslProvider.OPENSSL) ?
io.netty.handler.ssl.SslProvider.OPENSSL :
io.netty.handler.ssl.SslProvider.JDK;
sslCtx =
SslContextBuilder.forClient()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/reactor/netty/tcp/SslProvider.java
Expand Up @@ -367,7 +367,7 @@ void updateDefaultConfiguration() {
switch (type) {
case H2:
sslContextBuilder.sslProvider(
OpenSsl.isAlpnSupported() ?
io.netty.handler.ssl.SslProvider.isAlpnSupported(io.netty.handler.ssl.SslProvider.OPENSSL) ?
io.netty.handler.ssl.SslProvider.OPENSSL :
io.netty.handler.ssl.SslProvider.JDK)
.ciphers(Http2SecurityUtil.CIPHERS, SupportedCipherSuiteFilter.INSTANCE)
Expand Down
9 changes: 6 additions & 3 deletions src/test/java/reactor/netty/tcp/SslProviderTests.java
Expand Up @@ -103,7 +103,8 @@ public void testProtocolH2SslConfiguration() {
.bindNow();
assertEquals(2, protocols.size());
assertTrue(protocols.contains("h2"));
assertTrue(OpenSsl.isAlpnSupported() ? sslContext instanceof OpenSslContext :
assertTrue(io.netty.handler.ssl.SslProvider.isAlpnSupported(io.netty.handler.ssl.SslProvider.OPENSSL) ?
sslContext instanceof OpenSslContext :
sslContext instanceof JdkSslContext);
disposableServer.disposeNow();
}
Expand All @@ -116,7 +117,8 @@ public void testSslConfigurationProtocolH2_1() {
.bindNow();
assertEquals(2, protocols.size());
assertTrue(protocols.contains("h2"));
assertTrue(OpenSsl.isAlpnSupported() ? sslContext instanceof OpenSslContext :
assertTrue(io.netty.handler.ssl.SslProvider.isAlpnSupported(io.netty.handler.ssl.SslProvider.OPENSSL) ?
sslContext instanceof OpenSslContext :
sslContext instanceof JdkSslContext);
disposableServer.disposeNow();
}
Expand All @@ -130,7 +132,8 @@ public void testSslConfigurationProtocolH2_2() {
.bindNow();
assertEquals(2, protocols.size());
assertTrue(protocols.contains("h2"));
assertTrue(OpenSsl.isAlpnSupported() ? sslContext instanceof OpenSslContext :
assertTrue(io.netty.handler.ssl.SslProvider.isAlpnSupported(io.netty.handler.ssl.SslProvider.OPENSSL) ?
sslContext instanceof OpenSslContext :
sslContext instanceof JdkSslContext);
disposableServer.disposeNow();
}
Expand Down

0 comments on commit 7b7f380

Please sign in to comment.