Skip to content

Commit

Permalink
Remove useless check
Browse files Browse the repository at this point in the history
Reactor Netty version 1.2.0 will be released with Netty version > 4.1.98.Final
  • Loading branch information
violetagg committed Apr 17, 2024
1 parent 78f6651 commit 927d2d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ subprojects {
if (project.hasProperty("forceTransport")) {
systemProperty("forceTransport", forceTransport)
}
systemProperty("nettyVersionMicro", VersionNumber.parse(nettyVersion.toString()).micro)
systemProperty("reactorCoreVersionMinor", VersionNumber.parse(reactorCoreVersion.toString()).minor)
systemProperty("contextPropagationVersionMicro", VersionNumber.parse(contextPropagationVersion.toString()).micro)
scanForTestClasses = false
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2023 VMware, Inc. or its affiliates, All Rights Reserved.
* Copyright (c) 2018-2024 VMware, Inc. or its affiliates, All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -396,15 +396,7 @@ void testDefaultClientProviderIsOpenSsl() {

final OpenSslSessionContext sessionContext = clientContext.sessionContext();
assertThat(sessionContext.getSessionTimeout()).isEqualTo(300);
String nettyVersionMicro = System.getProperty("nettyVersionMicro");
// https://github.com/netty/netty/pull/13562
// This change enables client side session cache when using native SSL by default
if (nettyVersionMicro != null && !nettyVersionMicro.isEmpty() && Integer.parseInt(nettyVersionMicro) >= 98) {
assertThat(sessionContext.isSessionCacheEnabled()).isTrue();
}
else {
assertThat(sessionContext.isSessionCacheEnabled()).isFalse();
}
assertThat(sessionContext.isSessionCacheEnabled()).isTrue();
}

@Test
Expand Down

0 comments on commit 927d2d5

Please sign in to comment.