Avoid buf leak in TcpServerTests.retryStrategiesWhenServerFails by cl…

…osing BOUNDARY in NettyOutbound.sendGroups
reactor · Sep 20, 2022 · c47ba03 · c47ba03
1 parent 62c4407
commit c47ba03
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/reactor-netty5-core/src/main/java/reactor/netty5/NettyOutbound.java b/reactor-netty5-core/src/main/java/reactor/netty5/NettyOutbound.java
@@ -42,6 +42,7 @@
 import reactor.core.publisher.Mono;
 
 import static reactor.netty5.ReactorNetty.PREDICATE_GROUP_BOUNDARY;
+import static reactor.netty5.ReactorNetty.PREDICATE_GROUP_FLUSH;
 
 /**
  * An outbound-traffic API delegating to an underlying {@link Channel}.
@@ -236,7 +237,13 @@ default NettyOutbound sendGroups(Publisher<? extends Publisher<? extends Buffer>
 				    .concatMap(p -> Flux.<Buffer>from(p)
 				                        .concatWith(Mono.just(BOUNDARY.copy(0, BOUNDARY.readableBytes(), true))), 32)
 				    .doFinally(sig -> BOUNDARY.close()),
-				ReactorNetty.PREDICATE_GROUP_FLUSH);
+				buf -> {
+					boolean flush = PREDICATE_GROUP_FLUSH.test(buf);
+					if (flush) {
+						buf.close();
+					}
+					return flush;
+				});
 	}
 
 	/**