Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support X-Forwarded-* headers #220

Closed
bclozel opened this issue Nov 15, 2017 · 2 comments
Closed

Support X-Forwarded-* headers #220

bclozel opened this issue Nov 15, 2017 · 2 comments
Labels
type/enhancement A general enhancement
Milestone
0.8.0.M1

Comments

@bclozel
Copy link
Member

bclozel commented Nov 15, 2017

When an application sits behind an HTTP proxy terminating the TLS connection, the proxy sets X-Forwarded-* to tell the server about the original request: host, port, and protocol information.

Most servers (Tomcat, Undertow and Jetty) deal with that in their own codebase since it involves wrapping/changing the request information at a low level.

Could Reactor Netty support an HttpServerOption for enabling such a feature?

This should be disabled by default, as this could lead to attackers spoofing their peer address if there is no proxy in front of the application or if the proxy does not clean those incoming headers.
@bclozel bclozel added the type/enhancement A general enhancement label Nov 15, 2017
@bclozel bclozel mentioned this issue Nov 15, 2017
Closed
@smaldini smaldini added this to the 0.8.0.RELEASE milestone Nov 15, 2017
@nebhale
Copy link
Member

nebhale commented Nov 16, 2017

I wonder if it should also follow some of the Tomcat conventions (not sure about how the other two act) regarding internal proxies.

@smaldini smaldini modified the milestones: 0.8.0.RELEASE, 0.7.x Backlog Nov 20, 2017
bclozel added a commit to bclozel/reactor-netty that referenced this issue Dec 21, 2017
@bclozel
Add support for Forwarded / X-Forwarded-* headers
ce23436 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes reactorgh-220
@bclozel bclozel mentioned this issue Dec 21, 2017
Closed
bclozel added a commit to bclozel/reactor-netty that referenced this issue Dec 21, 2017
@bclozel
Add support for Forwarded / X-Forwarded-* headers
2159f09 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes reactorgh-220
bclozel added a commit to bclozel/reactor-netty that referenced this issue Jan 9, 2018
@bclozel
Add support for Forwarded / X-Forwarded-* headers
142fa2f 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes reactorgh-220
@violetagg violetagg modified the milestones: 0.8.x Backlog, 0.8.0.RELEASE Jan 9, 2018
violetagg added a commit that referenced this issue Jan 15, 2018
@violetagg
Add support for Forwarded / X-Forwarded-* headers
3147ad7 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg added a commit that referenced this issue Jan 15, 2018
@violetagg
Add support for Forwarded / X-Forwarded-* headers
5c43d6b 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
bclozel added a commit to bclozel/reactor-netty that referenced this issue Jan 15, 2018
@bclozel
Add support for Forwarded / X-Forwarded-* headers
e5a729c 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes reactorgh-220
violetagg pushed a commit that referenced this issue Jan 15, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
a8c9b24 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
@violetagg violetagg mentioned this issue Jan 15, 2018
Closed
@violetagg
Copy link
Member

Fixed by PR #249
Extended support will be covered by #259

violetagg pushed a commit that referenced this issue Jan 15, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
6627efb 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg pushed a commit that referenced this issue Jan 17, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
78b65e3 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg pushed a commit that referenced this issue Jan 19, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
583b4d4 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg pushed a commit that referenced this issue Jan 22, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
81bf19d 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg pushed a commit that referenced this issue Jan 24, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
cabe50f 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
@violetagg violetagg mentioned this issue May 14, 2018
Closed
24 tasks
violetagg pushed a commit that referenced this issue May 16, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
7ae2a8e 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
violetagg pushed a commit that referenced this issue May 28, 2018
@bclozel @violetagg
Add support for Forwarded / X-Forwarded-* headers
ce0c9e3 
This commit adds new information to the `HttpServerRequest`:
* the host (server) address
* the remote (client) address
* the scheme used by the current request

This information can be either derived from the current channel, or
extracted from the incoming HTTP request headers using "Forwarded"
or "X-Forwarded-*".

This feature is opt-in, and must be configured during server setup:

  HttpServer.create().forwarded().port(8080);

Closes gh-220
@violetagg violetagg modified the milestones: 0.8.0.RELEASE, 0.8.0.M1 Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
0.8.0.M1
Development

No branches or pull requests
4 participants
@nebhale @smaldini @bclozel @violetagg