Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Close events are not properly connected to pool release #285

Closed
smaldini opened this issue Feb 14, 2018 · 0 comments
Closed

Client Close events are not properly connected to pool release #285

smaldini opened this issue Feb 14, 2018 · 0 comments
Labels
type/bug A general bug
Milestone

Comments

@smaldini
Copy link
Contributor

As reported in cloudfoundry/cf-java-client#857, the client pooled context does not seem to bridge closeFuture correctly.

The core issue being that https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/ipc/netty/channel/PooledClientContextHandler.java#L200 is never true since the channel handler is created before by doPipeline. That means we never attach closeFuture(release(ch)).

@smaldini smaldini added the type/bug A general bug label Feb 14, 2018
@smaldini smaldini added this to the 0.7.4.RELEASE milestone Feb 14, 2018
simonbasle added a commit that referenced this issue Feb 19, 2018
only set the channel closeFuture to release to the pool once we've made
sure that we acquired a Channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant