Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling DNS retryOnTimeout with TCP #3059

Closed
claraccio opened this issue Feb 14, 2024 · 2 comments · Fixed by #3063
Closed

Enabling DNS retryOnTimeout with TCP #3059

claraccio opened this issue Feb 14, 2024 · 2 comments · Fixed by #3063
Assignees
@violetagg
Labels
type/enhancement A general enhancement
Milestone
1.1.17

Comments

@claraccio
Copy link

Netty sometimes get a 5000ms timeout error when querying DNS. e.g.
Caused by: io.netty.resolver.dns.DnsNameResolverTimeoutException: [19509: /172.33.0.2:53] DefaultDnsQuestion(<hidden> IN A) query '19509' via UDP timed out after 5000 milliseconds (no stack trace available)

The team has now merged this branch that allows for a retry over TCP instead of UDP, in case of timeout.
I do not think it is possible to set this boolean from reactor-netty?
I would expect it to be in the NameResolverProvider.NameResolverSpec

The merged branch:
netty/netty#13757
@claraccio claraccio added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Feb 14, 2024
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Feb 14, 2024
@violetagg violetagg added this to the 1.1.17 milestone Feb 14, 2024
@violetagg violetagg self-assigned this Feb 14, 2024
violetagg added a commit that referenced this issue Feb 16, 2024
@violetagg
Enable DNS retryOnTimeout with TCP
d895b83 
Add an API for configuring the resolver to fallback to TCP if a timeout is detected.
By default, the resolver will only try to use TCP if the response is marked as truncated.

Fixes #3059
@violetagg violetagg mentioned this issue Feb 16, 2024
Merged
violetagg added a commit that referenced this issue Feb 16, 2024
@violetagg
Enable DNS retryOnTimeout with TCP (#3063)
186c101 
Add an API for configuring the resolver to fallback to TCP if a timeout is detected.
By default, the resolver will only try to use TCP if the response is marked as truncated.

Fixes #3059
@violetagg
Copy link
Member

@claraccio You should be able to test the new configuration with 1.1.17-SNAPSHOT version.

@claraccio
Copy link
Author

I'll let it run in production and see, it's not an error that pops out often.

@cgual-omnidian cgual-omnidian mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.1.17
Development

Successfully merging a pull request may close this issue.

Enable DNS retryOnTimeout with TCP reactor/reactor-netty
2 participants
@violetagg @claraccio