Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid log pollution on server-side after client unsubscribes from SSE stream #339

Closed
sdeleuze opened this issue Apr 26, 2018 · 0 comments
Closed

Avoid log pollution on server-side after client unsubscribes from SSE stream #339

sdeleuze opened this issue Apr 26, 2018 · 0 comments
Labels
type/enhancement A general enhancement
Milestone
0.7.7.RELEASE

Comments

@sdeleuze
Copy link
Contributor

As described in SPR-16688, current logging strategy is not ideal because the stacktrace is not useful, the exception seems to be both logged and rethrown and we for some cases we don't have a specific exception to filter (generic IOException).

Here is a list of proposal to improve that:

  • Update Reactor Netty to follow WebFlux logging strategy, for example ChannelOperations#discreteRemoteClose could log stacktrace only at TRACE level, not at DEBUG nor ERROR ones since this provide very little added value and these errors are usual
  • Make sure Reactor Netty logs or emits the error, not both, to avoid double logging issues
  • Wrap the IOException emitted in ChannelOperations#discreteRemoteClose into a more specific one (maybe AbortedException?) to be able to filter it on Spring WebFlux side.
@violetagg violetagg added this to the 0.7.7.RELEASE milestone Apr 26, 2018
@violetagg violetagg added the type/enhancement A general enhancement label Apr 26, 2018
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 27, 2018
@sdeleuze
Fine tune WebFlux server logging verbosity
4fb1dc3 
With this commit, WebFlux server uses warning instead of error log level
for request handling error, and also just print the message instead of
the stacktrace which is mostly meaningless in reactive world.

Complementary to this change, Reactor Netty removed additional logging
as part of reactor/reactor-netty#339.

Issue: SPR-16688
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 27, 2018
@sdeleuze
Fine tune WebFlux server logging verbosity
7aba6ca 
With this commit, WebFlux server uses warning instead of error log level
for request handling, and also just print the message instead of the
stacktrace which is mostly meaningless in reactive world.

Complementary to this change, Reactor Netty removed additional logging
as part of reactor/reactor-netty#339.

Issue: SPR-16688
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Apr 27, 2018
@sdeleuze
Fine tune WebFlux server logging verbosity
75a41db 
With this commit, WebFlux server uses warning instead of error log level
for request handling, and also just print the message instead of the
stacktrace which is mostly meaningless in reactive world.

Complementary to this change, Reactor Netty removed additional logging
as part of reactor/reactor-netty#339.

Issue: SPR-16688
@rstoyanchev rstoyanchev mentioned this issue May 24, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
0.7.7.RELEASE
Development

No branches or pull requests
2 participants
@sdeleuze @violetagg