Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the warnings produced by errorprone compiler plugin #350

Closed
violetagg opened this issue May 7, 2018 · 0 comments · Fixed by #1367
Closed

Fix the warnings produced by errorprone compiler plugin #350

violetagg opened this issue May 7, 2018 · 0 comments · Fixed by #1367
Assignees
@violetagg
Labels
type/bug A general bug
Milestone
1.0.1

Comments

@violetagg
Copy link
Member

Related to #349
@violetagg violetagg added this to the 0.7.8.RELEASE milestone May 7, 2018
@violetagg violetagg added the type/bug A general bug label May 7, 2018
@violetagg violetagg mentioned this issue May 7, 2018
Merged
violetagg added a commit that referenced this issue May 7, 2018
@violetagg
Add the missing @OverRide
a551061 
Related to #350
violetagg added a commit that referenced this issue May 7, 2018
@violetagg
Express the duration time more clear in the tests
c0ae32e 
Lower the duration time in some tests
Related to #350
violetagg added a commit that referenced this issue May 7, 2018
@violetagg
Tests: Explicitly specify the charset that will be used
8d1286f 
Related to #350
violetagg added a commit that referenced this issue May 7, 2018
@violetagg
Use Objects#equals for HttpMethod and HttpResponseStatus comparison
534a5e8 
Objects#equals first does a reference equality comparison and then falls
back to content equality
Related to #350
violetagg added a commit that referenced this issue May 8, 2018
@violetagg
Use grouping parenthesis to make the operator precedence explicit
e4e1f02 
Related to #350
violetagg added a commit that referenced this issue May 8, 2018
@violetagg
Tests: Use StringBuilder instead of String Buffer
a19c86b 
Related to #350
violetagg added a commit that referenced this issue May 8, 2018
@violetagg
Tests: Make the inner class static
cdfbe66 
Reduce visibility
Related to #350
violetagg added a commit that referenced this issue May 8, 2018
@violetagg
Tests: log the exception instead of calling printStackTrace
da0c082 
Related to #350
@violetagg violetagg modified the milestones: 0.7.8.RELEASE, 0.7.x Maintenance Backlog Jun 6, 2018
violetagg added a commit that referenced this issue Jul 27, 2018
@violetagg
Tests: check the Future's return value
5396724 
Related to #350
violetagg added a commit that referenced this issue Jul 30, 2018
@violetagg
Handle use case when the queue is full
ff18677 
Related to #350
violetagg added a commit that referenced this issue Jul 30, 2018
@violetagg
Returned value deliberately ignored
3d84c45 
When adding/removing listener or setting promise status.

Related to #350
@violetagg violetagg modified the milestones: 0.7.x Maintenance Backlog, 0.8.x Maintenance Backlog Mar 11, 2019
@smaldini smaldini modified the milestones: 0.8.x Maintenance Backlog, 0.9.x Backlog Apr 1, 2019
@violetagg violetagg modified the milestones: 0.9.x Maintenance Backlog, 1.0.0 Backlog Oct 19, 2020
@violetagg violetagg modified the milestones: 1.0.0 Backlog, 1.0.1 Nov 5, 2020
violetagg added a commit that referenced this issue Nov 5, 2020
@violetagg
fix #350 Fix the warnings produced by errorprone compiler plugin
cb420a0
@violetagg violetagg mentioned this issue Nov 5, 2020
Merged
@violetagg violetagg self-assigned this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@violetagg violetagg

Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

fix #350 Fix the warnings produced by errorprone compiler plugin reactor/reactor-netty
2 participants
@smaldini @violetagg