Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have addEncoder/addDecoder skip if handler already exist, like legacy addHandler #46

Closed
simonbasle opened this issue Feb 16, 2017 · 0 comments
Closed

Have addEncoder/addDecoder skip if handler already exist, like legacy addHandler #46

simonbasle opened this issue Feb 16, 2017 · 0 comments
Assignees
@simonbasle
Labels
type/bug A general bug type/enhancement A general enhancement
Milestone
0.6.1.RELEASE

Comments

@simonbasle
Copy link
Member

addHandler used to check if there was an existing handler with the provided name, and skip the addition of the new handler if that was the case.
Since the move to addEncoder/addDecoder, this is no longer the case.

This should be fixed, for a minimum consistency with the previous API (even though the methods don't add at the same position as before).

Note that this is the inverse of #22 which would introduce a way of replacing instead of skipping.
@simonbasle simonbasle added type/bug A general bug type/enhancement A general enhancement labels Feb 16, 2017
@simonbasle simonbasle added this to the 0.6.1.RELEASE milestone Feb 16, 2017
@simonbasle simonbasle self-assigned this Feb 16, 2017
simonbasle added a commit that referenced this issue Feb 16, 2017
@simonbasle
fix #46 addEncoder/addDecoder skip handler if its name already exist
002d60b
@simonbasle simonbasle mentioned this issue Feb 16, 2017
Merged
simonbasle added a commit that referenced this issue Feb 17, 2017
@simonbasle
fix #46 addEncoder/addDecoder skip handler if its name already exist
b7f2c6b
simonbasle added a commit that referenced this issue Feb 17, 2017
@simonbasle
fix #46 addEncoder/addDecoder skip handler if its name already exist
38936fc
simonbasle added a commit that referenced this issue Feb 17, 2017
@simonbasle
see #46 addEncoder/addDecoder skip handler if its name already exist
85150a4 
This doesn't completely fix the issue as addHandler old behavior would
ignore the extractor and having an extractor breaks
JsonObjectDecoder...
simonbasle added a commit that referenced this issue Feb 20, 2017
@simonbasle
see #46 addEncoder/addDecoder skip handler if its name already exist
fa5bc55 
This doesn't completely fix the issue as addHandler old behavior would
ignore the extractor and having an extractor breaks
JsonObjectDecoder...
simonbasle added a commit that referenced this issue Feb 20, 2017
@simonbasle
see #46 Reintroduce addHandler as deprecated (skips the extractor)
f2f45d4
simonbasle added a commit that referenced this issue Feb 20, 2017
@simonbasle
see #46 Reintroduce addHandler as deprecated (skips the extractor)
6b7d120
simonbasle added a commit that referenced this issue Feb 20, 2017
@simonbasle
fix #46 Reintroduce addHandler as deprecated (skips the extractor)
93c0c30
simonbasle added a commit that referenced this issue Feb 20, 2017
@simonbasle
fix #46 addEncoder/addDecoder skip handler if its name already exist
2310338 
This is still not 100% equivalent to addHandler, which wouldn't add
an extractor... See #49 for a problem with the extractor.
@GarryIV GarryIV mentioned this issue Jan 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
type/bug A general bug type/enhancement A general enhancement
Projects
None yet
Milestone
0.6.1.RELEASE
Development

No branches or pull requests
1 participant
@simonbasle