ensures no compete on onSubscribe and onComplete calls #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
reviewed
Jun 28, 2021
also, this fix ensures that if we have addListener racing with cancel we always have all elements cleaned from the list Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
simonbasle
approved these changes
Jun 29, 2021
hyperxpro
reviewed
Jun 30, 2021
violetagg
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Please resolve the build warning:
> Task :reactor-netty-core:compileTestJava
/.../reactor-netty/reactor-netty-core/src/test/java/reactor/netty/FutureMonoTest.java:176: warning: [unchecked] unchecked cast
return (GenericFutureListener<? extends Future<?>>[]) listeners1.get(objListener);
^
required: GenericFutureListener<? extends Future<?>>[]
found: Object
1 warning
violetagg
approved these changes
Jun 30, 2021
|
@OlegDokuka Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1684
Signed-off-by: Oleh Dokuka odokuka@vmware.com
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com